Use logger #54
Open
Use logger #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the Travis build failure is an intermittent error, try re-running the job. By coincidence the output for the failed job in Travis provides a good example of showing errors only. |
|
I forced a rebuild and it passed this time. |
|
Updated to use SharedHelper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the noisy output when running rspec. All puts and printf statements are replaced by logger.info, logger.warn or logger.error. The logger provided in each sample defaults to INFO, while the logger in the spec is ERROR only. In either case the default can be overridden by setting environment variable LOGLEVEL.
I think using Logger in SDK samples adds value in being closer to real world usage. Having clean rspec output makes it easier to identify new issues and regressions.
This is a large diff for review, but the changes are relatively simple and consistent, mostly a global search/replace of puts with logger.info.