Skip to content

Conversation

@ChenYiLins
Copy link
Contributor

Feature: Mainly for updates of ThemePickerPage

Describe

Add ThemePickerPage.

Screenshots

image

image

Theme

image

Pick theme

image

Ignore

image

@ChenYiLins ChenYiLins added the area-winui3 Issues for winui3, version 11 or later label Apr 15, 2025
@ChenYiLins ChenYiLins requested review from a team, Armin2208 and Spiritreader as code owners April 15, 2025 13:32
@ChenYiLins ChenYiLins moved this to In review in Version 11.0 Apr 15, 2025
@ChenYiLins ChenYiLins self-assigned this Apr 15, 2025
@ChenYiLins
Copy link
Contributor Author

Looks like this is based before the large PR was merged. Don't know if that makes a difference?

Yep. But I feel there should be no problem.

@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Apr 15, 2025

I think the strings can be improved here-and-there too. More specific, but not more complicated. To give one example:

Now navigate to 'Colors' and change the system color to 'Light' for the light theme. Select your favorite Wallpaper, Mouse Cursor and Accent Color.

  • Where does user find "Colors"? (note that the link uses ThemeTutorialStep1 and is placed after the text)
  • Remove the "Now" bit
  • "Click here to open..." is text for dummies 🫢 Shouldn't be needed (proper words would be "Go to")

Header "ignore settings" is ambiguous: which settings are ignored? This app, or Windows?

@ChenYiLins
Copy link
Contributor Author

Code quality: Naming change

Describe

  • Changed the naming of some variables.
  • Replacement hardcoded.

@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Apr 21, 2025

Some of the names of the themes are trimmed, because those are the (folder and) .theme file names. Not really user-friendly.
image
image

To get the full name: it is store inside the .theme file under "DisplayName"
image

image

@ChenYiLins
Copy link
Contributor Author

Code quality: Naming recovery and theme file search rules

Describe

  • Revert to the last modified ViewModels naming.
  • Match only theme files.

Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Apr 23, 2025

First step to filling in the theme full names. This includes "Custom.theme", or "Not saved theme" at the top. Please check and finish. (I think ViewModel.SelectedLightTheme and ViewModel.SelectedDarkTheme must be used)
image

@Jay-o-Way Jay-o-Way force-pushed the winui3-themepicker branch from e86ef2e to 0b6adf0 Compare April 23, 2025 18:21
please check and finish where needed
@ChenYiLins
Copy link
Contributor Author

Regression: PersonalizationPage Message

Decribe

Add warning infobars in different scenarios and disable the corresponding SettingsCard.

Screenshots

image

image

@Jay-o-Way

This comment was marked as resolved.

@ChenYiLins
Copy link
Contributor Author

ChenYiLins commented Apr 27, 2025

Code quality: Change the severity to info and remove the title

Screenshots

image

Supplement

The disable button is actually working normally. The reason why the UI doesn't respond is because StateUpdateHandler has a serious error and is being fixed in the new branch.

@Armin2208
Copy link
Member

Looks nice, thank you!

@Jay-o-Way
Copy link
Contributor

Anything more that needs to be in this PR?

@ChenYiLins
Copy link
Contributor Author

@Jay-o-Way It seems that we have missed something. The topic under this directory: C:\Windows\Resources\Themes is missing.

@Jay-o-Way Jay-o-Way dismissed their stale review May 1, 2025 10:04

solved

@ChenYiLins
Copy link
Contributor Author

@Spiritreader Could we merge this PR? Looks like all things done.

@Spiritreader Spiritreader merged commit 888e707 into AutoDarkMode:winui3 May 11, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in Version 11.0 May 11, 2025
@ChenYiLins ChenYiLins deleted the winui3-themepicker branch May 12, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-winui3 Issues for winui3, version 11 or later

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants