-
-
Notifications
You must be signed in to change notification settings - Fork 291
Feature: Mainly for updates of ThemePickerPage #947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Mainly for updates of ThemePickerPage #947
Conversation
Yep. But I feel there should be no problem. |
|
I think the strings can be improved here-and-there too. More specific, but not more complicated. To give one example:
Header "ignore settings" is ambiguous: which settings are ignored? This app, or Windows? |
Code quality: Naming changeDescribe
|
Code quality: Naming recovery and theme file search rulesDescribe
|
Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
e86ef2e to
0b6adf0
Compare
please check and finish where needed
0b6adf0 to
0846813
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Looks nice, thank you! |
|
Anything more that needs to be in this PR? |
|
@Jay-o-Way It seems that we have missed something. The topic under this directory: C:\Windows\Resources\Themes is missing. |
|
@Spiritreader Could we merge this PR? Looks like all things done. |








Feature: Mainly for updates of ThemePickerPage
Describe
Add ThemePickerPage.
Screenshots
Theme
Pick theme
Ignore