Skip to content

fix: address PR #184 review feedback#196

Merged
leonvanzyl merged 1 commit intoAutoForgeAI:masterfrom
CaitlynByrne:fix/pr-184-feedback
Feb 15, 2026
Merged

fix: address PR #184 review feedback#196
leonvanzyl merged 1 commit intoAutoForgeAI:masterfrom
CaitlynByrne:fix/pr-184-feedback

Conversation

@CaitlynByrne
Copy link
Contributor

Summary

Changes

  • Select options validation: Each option in a select field must be a dict with non-empty value and label strings
  • Spurious options rejection: Fields with non-select types that include options are now rejected with a clear error

Already addressed in master

The other two items from the review were already fixed before merge:

  • Graph view handleGraphNodeClick already includes needs_human_input (App.tsx:130-135)
  • Progress fallback total already includes needs_human_input (App.tsx:249)

Test plan

  • Call feature_request_human_input with a select field missing value/label on options — should return error
  • Call with well-formed select options — should succeed
  • Call with options on a non-select field type — should return error
  • Run ruff check . — passes

🤖 Generated with Claude Code

 feedback)

Validate select option structure (value/label keys, non-empty strings)
and reject options on non-select field types.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@leonvanzyl leonvanzyl merged commit d65fa0c into AutoForgeAI:master Feb 15, 2026
2 checks passed
@leonvanzyl
Copy link
Collaborator

Thanks for the clean follow-up, @CaitlynByrne! The stricter select option validation and spurious options rejection look great. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants