-
Notifications
You must be signed in to change notification settings - Fork 368
feat: add Create Spec button and fix Windows asyncio subprocess #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,7 @@ | |
| --dev Run in development mode with Vite hot reload | ||
| """ | ||
|
|
||
| import asyncio | ||
| import os | ||
| import shutil | ||
| import socket | ||
|
|
@@ -28,6 +29,10 @@ | |
| import webbrowser | ||
| from pathlib import Path | ||
|
|
||
| # Fix Windows asyncio subprocess support BEFORE anything else runs | ||
| if sys.platform == "win32": | ||
| asyncio.set_event_loop_policy(asyncio.WindowsProactorEventLoopPolicy()) | ||
|
|
||
| ROOT = Path(__file__).parent.absolute() | ||
| VENV_DIR = ROOT / "venv" | ||
| UI_DIR = ROOT / "ui" | ||
|
|
@@ -259,17 +264,24 @@ def start_dev_server(port: int) -> tuple: | |
|
|
||
|
|
||
| def start_production_server(port: int): | ||
| """Start FastAPI server in production mode.""" | ||
| """Start FastAPI server in production mode with hot reload.""" | ||
| venv_python = get_venv_python() | ||
|
|
||
| print(f"\n Starting server at http://127.0.0.1:{port}") | ||
| print(f"\n Starting server at http://127.0.0.1:{port} (with hot reload)") | ||
|
|
||
| # Set PYTHONASYNCIODEBUG to help with Windows subprocess issues | ||
| env = os.environ.copy() | ||
|
|
||
| # NOTE: --reload is NOT used because on Windows it breaks asyncio subprocess | ||
| # support (uvicorn's reload worker doesn't inherit the ProactorEventLoop policy). | ||
| # This affects Claude SDK which uses asyncio.create_subprocess_exec. | ||
| # For development with hot reload, use: python start_ui.py --dev | ||
| return subprocess.Popen([ | ||
| str(venv_python), "-m", "uvicorn", | ||
| "server.main:app", | ||
| "--host", "127.0.0.1", | ||
| "--port", str(port) | ||
| ], cwd=str(ROOT)) | ||
| "--port", str(port), | ||
| ], cwd=str(ROOT), env=env) | ||
|
Comment on lines
189
to
+207
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix misleading hot‑reload messaging and env comment.
📝 Suggested cleanup-def start_production_server(port: int):
- """Start FastAPI server in production mode with hot reload."""
+def start_production_server(port: int):
+ """Start FastAPI server in production mode."""
@@
- print(f"\n Starting server at http://127.0.0.1:{port} (with hot reload)")
+ print(f"\n Starting server at http://127.0.0.1:{port}")
@@
- # Set PYTHONASYNCIODEBUG to help with Windows subprocess issues
env = os.environ.copy()
+ # Optional: enable asyncio debug when troubleshooting Windows subprocess issues
+ # env["PYTHONASYNCIODEBUG"] = "1"🤖 Prompt for AI Agents |
||
|
|
||
|
|
||
| def main() -> None: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid killing unrelated processes on port 8888.
The current block force-kills any listener on 8888, which can terminate unrelated services. Consider prompting the user (or filtering to expected process names) before killing.
🐛 Proposed safer prompt before killing
🤖 Prompt for AI Agents