fix(s3stream): prevent sort on unmodifiable list; delete unused code

Signed-off-by: Shichao Nie <niesc@automq.com>
AutoMQ · Oct 26, 2023 · 06fec55 · 06fec55
1 parent 3ad0d6a
commit 06fec55
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 201 deletions.
diff --git a/s3stream/src/main/java/com/automq/stream/s3/compact/AsyncTokenBucketThrottle.java b/s3stream/src/main/java/com/automq/stream/s3/compact/AsyncTokenBucketThrottle.java
diff --git a/s3stream/src/main/java/com/automq/stream/s3/compact/CompactionManager.java b/s3stream/src/main/java/com/automq/stream/s3/compact/CompactionManager.java
@@ -132,7 +132,7 @@ private CompletableFuture<CompactResult> compact() {
             List<Long> streamIds = objectMetadataList.stream().flatMap(e -> e.getOffsetRanges().stream())
                     .map(StreamOffsetRange::getStreamId).distinct().toList();
             return this.streamManager.getStreams(streamIds).thenApplyAsync(streamMetadataList -> {
-                List<S3ObjectMetadata> s3ObjectMetadataList = objectMetadataList;
+                List<S3ObjectMetadata> s3ObjectMetadataList = new ArrayList<>(objectMetadataList);
                 if (s3ObjectMetadataList.isEmpty()) {
                     logger.info("No WAL objects to compact");
                     return CompactResult.SKIPPED;

diff --git a/s3stream/src/main/java/com/automq/stream/s3/compact/TokenBucketThrottle.java b/s3stream/src/main/java/com/automq/stream/s3/compact/TokenBucketThrottle.java
diff --git a/s3stream/src/test/java/com/automq/stream/s3/compact/AsyncTokenBucketThrottleTest.java b/s3stream/src/test/java/com/automq/stream/s3/compact/AsyncTokenBucketThrottleTest.java