fix(s3stream/wal): automatically detected whether to use direct IO by… (

#698) Signed-off-by: Ning Yu <ningyu@automq.com>
AutoMQ · Nov 22, 2023 · cc5c862 · cc5c862
1 parent 1c99473
commit cc5c862
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/s3stream/src/main/java/com/automq/stream/s3/wal/BlockWALService.java b/s3stream/src/main/java/com/automq/stream/s3/wal/BlockWALService.java
@@ -511,7 +511,7 @@ private SlidingWindowService.WALHeaderFlusher flusher() {
     public static class BlockWALServiceBuilder {
         private final String blockDevicePath;
         private long blockDeviceCapacityWant = CAPACITY_NOT_SET;
-        private boolean direct = false;
+        private Boolean direct = null;
         private int initBufferSize = 1 << 20; // 1MiB
         private int maxBufferSize = 1 << 24; // 16MiB
         private int ioThreadNums = 8;
@@ -621,13 +621,15 @@ public BlockWALService build() {
 
             BlockWALService blockWALService = new BlockWALService();
 
-            blockWALService.walChannel = WALChannel.builder(blockDevicePath)
+            WALChannel.WALChannelBuilder walChannelBuilder = WALChannel.builder(blockDevicePath)
                     .capacity(blockDeviceCapacityWant)
-                    .direct(direct)
                     .initBufferSize(initBufferSize)
                     .maxBufferSize(maxBufferSize)
-                    .recoveryMode(recoveryMode)
-                    .build();
+                    .recoveryMode(recoveryMode);
+            if (direct != null) {
+                walChannelBuilder.direct(direct);
+            }
+            blockWALService.walChannel = walChannelBuilder.build();
             if (!blockWALService.walChannel.useDirectIO()) {
                 LOGGER.info("block wal not using direct IO");
             }