Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(s3stream/wal): marshal records lazily #464

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

Chillax-0v0
Copy link
Contributor

No description provided.

Signed-off-by: Ning Yu <ningyu@automq.com>
Signed-off-by: Ning Yu <ningyu@automq.com>
@Chillax-0v0 Chillax-0v0 added s3stream wal the WAL of S3 stream labels Oct 25, 2023
@Chillax-0v0 Chillax-0v0 self-assigned this Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #464 (2488cb0) into main (e1b8f89) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #464      +/-   ##
============================================
- Coverage     56.69%   56.68%   -0.01%     
- Complexity      813      817       +4     
============================================
  Files           100      101       +1     
  Lines          6147     6176      +29     
  Branches        588      589       +1     
============================================
+ Hits           3485     3501      +16     
- Misses         2323     2336      +13     
  Partials        339      339              
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 23.33% <0.00%> (-0.40%) ⬇️
RocketMQ Controller 57.75% <0.00%> (-0.01%) ⬇️
RocketMQ Proxy 36.78% <ø> (ø)
RocketMQ Store 74.20% <ø> (ø)
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 16.98% <ø> (ø)
Files Coverage Δ
...java/com/automq/rocketmq/common/api/DataStore.java 0.00% <0.00%> (ø)
...etmq/controller/metadata/GrpcControllerClient.java 63.20% <0.00%> (-0.96%) ⬇️
...roller/metadata/database/DefaultMetadataStore.java 52.65% <0.00%> (-0.48%) ⬇️
...omq/rocketmq/controller/ControllerServiceImpl.java 63.92% <0.00%> (-0.36%) ⬇️

... and 3 files with indirect coverage changes

@github-actions
Copy link

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@superhx superhx merged commit eb73823 into main Oct 25, 2023
7 of 9 checks passed
@superhx superhx deleted the perf-wal-crc-async branch October 25, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s3stream wal the WAL of S3 stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants