feat(proxy): introduce TimerService #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for JVM4 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
ShadowySpirits
force-pushed
the
timer_service
branch
from
807855e
to
2a1614d
Compare
Signed-off-by: SSpirits <admin@lv5.moe>
ShadowySpirits
force-pushed
the
timer_service
branch
from
2a1614d
to
7b884a1
Compare
Signed-off-by: SSpirits <admin@lv5.moe>
|
The author of this PR, ShadowySpirits, is not an activated member of this organization on Codecov. |
daniel-y
reviewed
Oct 28, 2023
| import org.apache.rocketmq.logging.org.slf4j.Logger; | ||
| import org.apache.rocketmq.logging.org.slf4j.LoggerFactory; | ||
|
|
||
| public abstract class ServiceThread implements Runnable, Lifecycle { |
There was a problem hiding this comment.
这个不考虑直接用rocketmq内置的ServiceThread么。。
There was a problem hiding this comment.
store没有依赖rocketmq
daniel-y
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #483