Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup metadata support via database #55

Merged
merged 2 commits into from
Sep 19, 2023
Merged

feat: setup metadata support via database #55

merged 2 commits into from
Sep 19, 2023

Conversation

lizhanhui
Copy link
Contributor

No description provided.

Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #55 (95135e9) into main (38f9b62) will decrease coverage by 2.72%.
The diff coverage is 40.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #55      +/-   ##
============================================
- Coverage     72.88%   70.16%   -2.72%     
+ Complexity      166      124      -42     
============================================
  Files            35       30       -5     
  Lines           745      590     -155     
  Branches         71       63       -8     
============================================
- Hits            543      414     -129     
+ Misses          164      148      -16     
+ Partials         38       28      -10     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 60.00% <ø> (+11.72%) ⬆️
RocketMQ Controller 10.41% <40.00%> (-44.20%) ⬇️
RocketMQ Proxy ∅ <ø> (∅)
RocketMQ Store 76.20% <ø> (-5.81%) ⬇️
Files Changed Coverage Δ
...omq/rocketmq/controller/ControllerServiceImpl.java 0.00% <0.00%> (ø)
...ntroller/metadata/database/MetadataStoreMySQL.java 0.00% <0.00%> (ø)
...r/metadata/database/HikariCPDataSourceFactory.java 100.00% <100.00%> (ø)

... and 17 files with indirect coverage changes

Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
@lizhanhui lizhanhui merged commit f5282b5 into main Sep 19, 2023
5 of 8 checks passed
@lizhanhui lizhanhui deleted the metadata-db branch September 19, 2023 11:41
daniel-y pushed a commit that referenced this pull request Sep 27, 2023
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
daniel-y pushed a commit that referenced this pull request Sep 27, 2023
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant