Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): skip initializing StreamMetricsManager when exporter disabled #557

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

TheR1sing3un
Copy link
Contributor

  1. Skip initializing StreamMetricsManager when exported disabled

Copy link

codecov bot commented Nov 3, 2023

The author of this PR, TheR1sing3un, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at support@codecov.io with any questions.

Copy link

github-actions bot commented Nov 3, 2023

Qodana for JVM

1 new problem were found

Inspection name Severity Problems
Field may be 'final' 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

…bled

1. skip initializing StreamMetricsManager when exporter disabled

Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
@TheR1sing3un TheR1sing3un changed the title fix(store): skip initializing StreamMetricsManager when exported disabled fix(store): skip initializing StreamMetricsManager when exporter disabled Nov 3, 2023
@TheR1sing3un TheR1sing3un enabled auto-merge (rebase) November 3, 2023 02:25
@TheR1sing3un TheR1sing3un merged commit edbca63 into main Nov 6, 2023
9 of 10 checks passed
@TheR1sing3un TheR1sing3un deleted the fix_stream_metrics branch November 6, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants