Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(issues575-issue575): rename WAL object to SST object #580

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

superhx
Copy link
Contributor

@superhx superhx commented Nov 6, 2023

close #575

Signed-off-by: Robin Han <hanxvdovehx@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Nov 6, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #580 (b14815b) into main (9ce85d9) will increase coverage by 0.15%.
Report is 1 commits behind head on main.
The diff coverage is 56.42%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #580      +/-   ##
============================================
+ Coverage     58.98%   59.14%   +0.15%     
- Complexity     1903     1905       +2     
============================================
  Files           196      196              
  Lines         12778    12776       -2     
  Branches       1219     1218       -1     
============================================
+ Hits           7537     7556      +19     
+ Misses         4627     4609      -18     
+ Partials        614      611       -3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 12.96% <ø> (ø)
RocketMQ Controller 49.69% <ø> (+0.53%) ⬆️
RocketMQ Proxy 44.45% <ø> (+0.19%) ⬆️
RocketMQ Store 77.95% <9.52%> (+0.05%) ⬆️
RocketMQ Stream 60.62% <60.23%> (+0.03%) ⬆️
RocketMQ Metadata 62.95% <ø> (ø)
Files Coverage Δ
.../com/automq/stream/s3/compact/CompactionStats.java 90.90% <100.00%> (ø)
...om/automq/stream/s3/metadata/S3ObjectMetadata.java 40.81% <ø> (ø)
...va/com/automq/stream/s3/metadata/S3ObjectType.java 50.00% <100.00%> (ø)
...tomq/stream/s3/objects/CommitSSTObjectRequest.java 76.47% <100.00%> (ø)
...omq/stream/s3/objects/CommitSSTObjectResponse.java 100.00% <100.00%> (ø)
...ava/com/automq/rocketmq/store/S3ObjectManager.java 92.00% <100.00%> (ø)
.../java/com/automq/stream/s3/DeltaWALUploadTask.java 93.33% <95.45%> (ø)
...m/automq/stream/s3/compact/CompactionAnalyzer.java 86.56% <90.90%> (ø)
...main/java/com/automq/stream/s3/S3StreamClient.java 0.00% <0.00%> (ø)
...m/automq/stream/s3/compact/CompactionUploader.java 84.81% <84.00%> (ø)
... and 6 more

... and 9 files with indirect coverage changes

Copy link

github-actions bot commented Nov 6, 2023

Qodana for JVM

2 new problems were found

Inspection name Severity Problems
Field can be local 🔶 Warning 1
Duplicated code fragment ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@superhx superhx merged commit 1d741b6 into main Nov 6, 2023
9 of 10 checks passed
@superhx superhx deleted the refactor_issue575 branch November 6, 2023 07:42
lizhanhui pushed a commit that referenced this pull request Nov 7, 2023
Signed-off-by: Robin Han <hanxvdovehx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename WAL object to Sorted Stream Table
3 participants