Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default database connection pool size #593

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

lizhanhui
Copy link
Contributor

@lizhanhui lizhanhui commented Nov 7, 2023

to #589

Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Nov 7, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Nov 7, 2023

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #593 (449b87e) into main (52a7a0a) will decrease coverage by 0.01%.
The diff coverage is 14.28%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #593      +/-   ##
============================================
- Coverage     59.02%   59.01%   -0.01%     
+ Complexity     1909     1907       -2     
============================================
  Files           196      196              
  Lines         12811    12816       +5     
  Branches       1220     1220              
============================================
+ Hits           7562     7564       +2     
  Misses         4638     4638              
- Partials        611      614       +3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 12.96% <ø> (ø)
RocketMQ Controller 49.46% <ø> (+0.26%) ⬆️
RocketMQ Proxy 44.35% <ø> (ø)
RocketMQ Store 77.61% <0.00%> (-0.36%) ⬇️
RocketMQ Stream 60.58% <ø> (-0.04%) ⬇️
RocketMQ Metadata 17.64% <ø> (ø)
Files Coverage Δ
...q/rocketmq/metadata/HikariCPDataSourceFactory.java 100.00% <100.00%> (ø)
...ava/com/automq/rocketmq/store/DataStoreFacade.java 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@lizhanhui lizhanhui merged commit 121e70c into main Nov 7, 2023
8 of 11 checks passed
@lizhanhui lizhanhui deleted the connection_pool branch November 7, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants