Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3stream): optimization on crc calculation #596

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat(s3stream): optimization on crc calculation #596

merged 1 commit into from
Nov 8, 2023

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Nov 7, 2023

No description provided.

Signed-off-by: Shichao Nie <niesc@automq.com>
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #596 (b99a3d4) into main (960631c) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #596      +/-   ##
============================================
+ Coverage     58.84%   59.00%   +0.15%     
- Complexity     1909     1910       +1     
============================================
  Files           196      196              
  Lines         12838    12837       -1     
  Branches       1220     1220              
============================================
+ Hits           7555     7574      +19     
+ Misses         4671     4649      -22     
- Partials        612      614       +2     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 12.96% <ø> (ø)
RocketMQ Controller 49.46% <ø> (+0.11%) ⬆️
RocketMQ Proxy 44.35% <ø> (ø)
RocketMQ Store 77.77% <ø> (+0.88%) ⬆️
RocketMQ Stream 60.48% <100.00%> (-0.01%) ⬇️
RocketMQ Metadata 17.64% <ø> (ø)
Files Coverage Δ
...in/java/com/automq/stream/s3/wal/util/WALUtil.java 83.33% <100.00%> (-1.29%) ⬇️

... and 5 files with indirect coverage changes

Copy link

github-actions bot commented Nov 7, 2023

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@superhx superhx merged commit e4e79a8 into main Nov 8, 2023
10 checks passed
@superhx superhx deleted the crc_opt branch November 8, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants