Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3stream): check read permits before merge read task #610

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Nov 9, 2023

No description provided.

Signed-off-by: Shichao Nie <niesc@automq.com>
@SCNieh SCNieh requested a review from superhx November 9, 2023 12:39
Copy link

github-actions bot commented Nov 9, 2023

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #610 (6a95f86) into main (992fa4c) will decrease coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #610      +/-   ##
============================================
- Coverage     59.03%   58.97%   -0.07%     
- Complexity     1939     1942       +3     
============================================
  Files           199      199              
  Lines         13054    13054              
  Branches       1195     1195              
============================================
- Hits           7707     7698       -9     
- Misses         4729     4741      +12     
+ Partials        618      615       -3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 12.96% <ø> (ø)
RocketMQ Controller 50.38% <ø> (-0.12%) ⬇️
RocketMQ Proxy 43.45% <ø> (+0.12%) ⬆️
RocketMQ Store 77.68% <ø> (-0.40%) ⬇️
RocketMQ Stream 60.45% <100.00%> (ø)
RocketMQ Metadata 38.28% <ø> (ø)
Files Coverage Δ
...m/automq/stream/s3/operator/DefaultS3Operator.java 48.64% <100.00%> (ø)

... and 10 files with indirect coverage changes

@superhx superhx merged commit 48031fa into main Nov 10, 2023
9 of 10 checks passed
@superhx superhx deleted the read_ahead branch November 10, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants