Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include node-id in close-stream-request during forwarding requests #738

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

lizhanhui
Copy link
Contributor

fix #737

Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
@lizhanhui lizhanhui enabled auto-merge (squash) November 27, 2023 10:12
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #738 (3d70e50) into main (aa5f1ef) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #738      +/-   ##
============================================
+ Coverage     57.33%   57.36%   +0.03%     
- Complexity     1221     1224       +3     
============================================
  Files           131      131              
  Lines          8046     8047       +1     
  Branches        736      736              
============================================
+ Hits           4613     4616       +3     
- Misses         3034     3035       +1     
+ Partials        399      396       -3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.60% <0.00%> (-0.02%) ⬇️
RocketMQ Proxy 42.75% <ø> (+0.12%) ⬆️
RocketMQ Store 77.00% <ø> (+0.04%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)
Files Coverage Δ
...mq/controller/server/store/impl/StreamManager.java 63.74% <0.00%> (-0.19%) ⬇️

... and 2 files with indirect coverage changes

@lizhanhui lizhanhui merged commit 6634b68 into main Nov 27, 2023
10 of 11 checks passed
@lizhanhui lizhanhui deleted the fix_737 branch November 27, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: close stream remote misses node-id
2 participants