Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3stream): blockCache performance optimization #766

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Nov 29, 2023

optimized to concurrent read from different objects

optimized to concurrent read from different objects

Signed-off-by:
Shichao Nie <niesc@automq.com>

Signed-off-by: Shichao Nie <niesc@automq.com>
@SCNieh SCNieh requested a review from superhx November 29, 2023 12:10
@SCNieh
Copy link
Contributor Author

SCNieh commented Nov 29, 2023

#748 #747

Signed-off-by: Shichao Nie <niesc@automq.com>
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #766 (7752072) into main (71b01b9) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #766      +/-   ##
============================================
- Coverage     57.53%   57.51%   -0.03%     
+ Complexity     1223     1221       -2     
============================================
  Files           131      131              
  Lines          8042     8042              
  Branches        740      740              
============================================
- Hits           4627     4625       -2     
  Misses         3017     3017              
- Partials        398      400       +2     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 55.13% <ø> (ø)
RocketMQ Proxy 42.62% <ø> (-0.13%) ⬇️
RocketMQ Store 76.96% <ø> (ø)
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 1 file with indirect coverage changes

@SCNieh SCNieh merged commit 60cfe08 into main Nov 29, 2023
9 of 11 checks passed
@SCNieh SCNieh deleted the read_ahead branch November 29, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants