Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3stream): clean up buffer on compaction exception #799

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Dec 5, 2023

No description provided.

@SCNieh SCNieh requested a review from superhx December 5, 2023 12:59
Signed-off-by: Shichao Nie <niesc@automq.com>
Signed-off-by: Shichao Nie <niesc@automq.com>
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #799 (f478603) into main (99c0fb7) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #799   +/-   ##
=========================================
  Coverage     57.62%   57.62%           
+ Complexity     1231     1230    -1     
=========================================
  Files           132      132           
  Lines          8109     8109           
  Branches        745      745           
=========================================
  Hits           4673     4673           
+ Misses         3034     3033    -1     
- Partials        402      403    +1     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 55.13% <ø> (ø)
RocketMQ Proxy 42.61% <ø> (-0.13%) ⬇️
RocketMQ Store 76.99% <ø> (+0.09%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 2 files with indirect coverage changes

@superhx superhx merged commit 7563d05 into main Dec 6, 2023
13 of 14 checks passed
@superhx superhx deleted the compaction branch December 6, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants