Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3stream/wal): check whether the file system supports direct IO #808

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

Chillax-0v0
Copy link
Contributor

No description provided.

Signed-off-by: Ning Yu <ningyu@automq.com>
@Chillax-0v0 Chillax-0v0 added bug Something isn't working s3stream wal the WAL of S3 stream labels Dec 6, 2023
@Chillax-0v0 Chillax-0v0 self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #808 (ce05ea8) into main (54188ec) will decrease coverage by 0.80%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #808      +/-   ##
============================================
- Coverage     56.15%   55.35%   -0.80%     
  Complexity     1229     1229              
============================================
  Files           132      132              
  Lines          8325     8447     +122     
  Branches        765      773       +8     
============================================
+ Hits           4675     4676       +1     
- Misses         3244     3366     +122     
+ Partials        406      405       -1     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 55.13% <ø> (ø)
RocketMQ Proxy 36.89% <ø> (-2.54%) ⬇️
RocketMQ Store 74.34% <ø> (+0.04%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 5 files with indirect coverage changes

@Chillax-0v0 Chillax-0v0 marked this pull request as draft December 6, 2023 13:53
@Chillax-0v0
Copy link
Contributor Author

FIXME: No need to check whether the file system supports direct IO when writing to block devices.

Signed-off-by: Ning Yu <ningyu@automq.com>
@Chillax-0v0 Chillax-0v0 marked this pull request as ready for review December 7, 2023 08:16
@superhx superhx merged commit 0a7e33c into main Dec 7, 2023
12 of 15 checks passed
@superhx superhx deleted the fix-wal-check-direct-io branch December 7, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working s3stream wal the WAL of S3 stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants