Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3stream): add missing inflight read key on async read ahead #829

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Dec 13, 2023

No description provided.

Signed-off-by: Shichao Nie <niesc@automq.com>
@SCNieh SCNieh requested a review from superhx December 13, 2023 07:59
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #829 (47da87b) into main (be55d79) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #829      +/-   ##
============================================
+ Coverage     56.38%   56.40%   +0.01%     
- Complexity     1260     1264       +4     
============================================
  Files           132      132              
  Lines          8524     8530       +6     
  Branches        785      787       +2     
============================================
+ Hits           4806     4811       +5     
+ Misses         3284     3282       -2     
- Partials        434      437       +3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 57.39% <ø> (ø)
RocketMQ Proxy 37.71% <ø> (+0.26%) ⬆️
RocketMQ Store 74.27% <ø> (-0.06%) ⬇️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 4 files with indirect coverage changes

#read0

Signed-off-by: Shichao Nie <niesc@automq.com>
@superhx superhx enabled auto-merge (squash) December 13, 2023 09:48
@superhx superhx merged commit 72d34d8 into main Dec 13, 2023
8 checks passed
@superhx superhx deleted the fix_stream_reader branch December 13, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants