Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3stream): remove future before complete it to prevent infinite r… #830

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Dec 13, 2023

…ecursion

…ecursion

Signed-off-by: Shichao Nie <niesc@automq.com>
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #830 (618e4a2) into main (72d34d8) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #830      +/-   ##
============================================
- Coverage     56.40%   56.38%   -0.02%     
+ Complexity     1263     1262       -1     
============================================
  Files           132      132              
  Lines          8530     8530              
  Branches        787      787              
============================================
- Hits           4811     4810       -1     
  Misses         3282     3282              
- Partials        437      438       +1     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 57.39% <ø> (ø)
RocketMQ Proxy 37.71% <ø> (ø)
RocketMQ Store 74.23% <ø> (-0.05%) ⬇️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 1 file with indirect coverage changes

@superhx superhx merged commit d1cdb6b into main Dec 13, 2023
11 checks passed
@superhx superhx deleted the fix_sof branch December 13, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants