Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(s3stream): downgrade OT version to java8 #832

Merged
merged 1 commit into from
Dec 15, 2023
Merged

build(s3stream): downgrade OT version to java8 #832

merged 1 commit into from
Dec 15, 2023

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Dec 14, 2023

No description provided.

@SCNieh SCNieh requested a review from superhx December 14, 2023 12:46
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #832 (46ffecd) into main (08d1462) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #832      +/-   ##
============================================
+ Coverage     55.47%   55.49%   +0.02%     
- Complexity     1242     1244       +2     
============================================
  Files           132      132              
  Lines          8530     8530              
  Branches        787      787              
============================================
+ Hits           4732     4734       +2     
  Misses         3380     3380              
+ Partials        418      416       -2     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (ø)
RocketMQ Proxy 37.81% <ø> (+0.10%) ⬆️
RocketMQ Store 74.27% <ø> (ø)
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 1 file with indirect coverage changes

Copy link
Contributor

@ShadowySpirits ShadowySpirits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please exclude this dependency from the rocketmq pom.

@superhx superhx enabled auto-merge (squash) December 15, 2023 01:50
Signed-off-by: Shichao Nie <niesc@automq.com>
@superhx superhx merged commit 755d225 into main Dec 15, 2023
14 checks passed
@superhx superhx deleted the s3_metrics branch December 15, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants