Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proxy): add metrics and trace for remoting send and pull RPC #844

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

ShadowySpirits
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #844 (0d76801) into main (e268e19) will decrease coverage by 0.15%.
Report is 1 commits behind head on main.
The diff coverage is 26.56%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #844      +/-   ##
============================================
- Coverage     55.49%   55.35%   -0.15%     
- Complexity     1244     1250       +6     
============================================
  Files           132      132              
  Lines          8530     8574      +44     
  Branches        787      788       +1     
============================================
+ Hits           4734     4746      +12     
- Misses         3380     3414      +34     
+ Partials        416      414       -2     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (ø)
RocketMQ Proxy 37.28% <20.00%> (-0.53%) ⬇️
RocketMQ Store 74.62% <66.66%> (+0.34%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)
Files Coverage Δ
...java/com/automq/rocketmq/store/api/LogicQueue.java 92.30% <ø> (ø)
.../automq/rocketmq/store/queue/StreamLogicQueue.java 73.75% <100.00%> (+2.27%) ⬆️
...m/automq/rocketmq/store/service/ReviveService.java 85.27% <100.00%> (ø)
...omq/rocketmq/proxy/service/MessageServiceImpl.java 53.06% <91.66%> (+0.64%) ⬆️
...va/com/automq/rocketmq/store/MessageStoreImpl.java 45.80% <0.00%> (+0.34%) ⬆️
...y/remoting/activity/ExtendPullMessageActivity.java 0.00% <0.00%> (ø)
...y/remoting/activity/ExtendSendMessageActivity.java 0.00% <0.00%> (ø)

@ShadowySpirits ShadowySpirits merged commit 2a7d4c2 into main Dec 19, 2023
12 of 13 checks passed
@ShadowySpirits ShadowySpirits deleted the remoting_trace branch December 19, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant