Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3stream): introduce tracing to s3stream #866

Merged
merged 4 commits into from
Dec 28, 2023
Merged

feat(s3stream): introduce tracing to s3stream #866

merged 4 commits into from
Dec 28, 2023

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Dec 28, 2023

No description provided.

Signed-off-by: Shichao Nie <niesc@automq.com>
Signed-off-by: Shichao Nie <niesc@automq.com>
Signed-off-by: Shichao Nie <niesc@automq.com>
Signed-off-by: Shichao Nie <niesc@automq.com>
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (99ba37c) 55.01% compared to head (1aa6583) 54.99%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #866      +/-   ##
============================================
- Coverage     55.01%   54.99%   -0.02%     
- Complexity     1244     1246       +2     
============================================
  Files           132      133       +1     
  Lines          8531     8535       +4     
  Branches        789      789              
============================================
+ Hits           4693     4694       +1     
- Misses         3422     3426       +4     
+ Partials        416      415       -1     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (ø)
RocketMQ Proxy 37.28% <ø> (+0.10%) ⬆️
RocketMQ Store 73.57% <0.00%> (-0.19%) ⬇️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)
Files Coverage Δ
.../java/com/automq/rocketmq/store/S3StreamStore.java 0.00% <ø> (ø)
...va/com/automq/rocketmq/store/util/ContextUtil.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@SCNieh SCNieh enabled auto-merge (squash) December 28, 2023 07:52
@SCNieh SCNieh merged commit 6264c96 into main Dec 28, 2023
7 of 8 checks passed
@SCNieh SCNieh deleted the s3_trace branch December 28, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants