Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize S3Utils output #895

Merged
merged 1 commit into from
Jan 15, 2024
Merged

chore: optimize S3Utils output #895

merged 1 commit into from
Jan 15, 2024

Conversation

KaimingWan
Copy link
Contributor

@KaimingWan KaimingWan commented Jan 12, 2024

Give a more readable output of check message like :

[ OK ] Write s3 object
[ OK ] Read s3 object
[ OK ] Delete s3 object
[ OK ] Write S3 object
[ OK ] Upload s3 multipart object
[ OK ] Read s3 multipart object
[ OK ] Delete s3 object

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87098f5) 54.98% compared to head (5dcfdf8) 55.01%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #895      +/-   ##
============================================
+ Coverage     54.98%   55.01%   +0.03%     
- Complexity     1243     1246       +3     
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
+ Hits           4692     4695       +3     
  Misses         3425     3425              
+ Partials        417      414       -3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (ø)
RocketMQ Proxy 37.28% <ø> (+0.10%) ⬆️
RocketMQ Store 73.65% <ø> (+0.04%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 2 files with indirect coverage changes

@KaimingWan KaimingWan merged commit b9662a2 into main Jan 15, 2024
8 checks passed
@KaimingWan KaimingWan deleted the chore/admin_support_2 branch January 15, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants