Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3stream): reduce histogram sample size by dividing into explicit percentiles #956

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Mar 6, 2024

No description provided.

…t percentiles

Signed-off-by: Shichao Nie <niesc@automq.com>
…t percentiles

Signed-off-by: Shichao Nie <niesc@automq.com>
@SCNieh SCNieh requested a review from superhx March 6, 2024 08:25
Signed-off-by: Shichao Nie <niesc@automq.com>
@SCNieh SCNieh enabled auto-merge (squash) March 6, 2024 08:55
Signed-off-by: Shichao Nie <niesc@automq.com>
@SCNieh SCNieh disabled auto-merge March 6, 2024 09:23
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.92%. Comparing base (c6c0a36) to head (7b8b7d5).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #956      +/-   ##
============================================
+ Coverage     55.91%   55.92%   +0.01%     
- Complexity     1265     1267       +2     
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
+ Hits           4772     4773       +1     
  Misses         3327     3327              
+ Partials        435      434       -1     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 57.39% <ø> (ø)
RocketMQ Proxy 37.28% <ø> (+0.10%) ⬆️
RocketMQ Store 73.60% <ø> (-0.05%) ⬇️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 2 files with indirect coverage changes

@SCNieh SCNieh merged commit c332510 into main Mar 6, 2024
8 checks passed
@SCNieh SCNieh deleted the metrics branch March 6, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants