Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(s3stream): remove the source code of s3stream, and dependency it via submodule #963

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

daniel-y
Copy link
Contributor

@daniel-y daniel-y commented Apr 7, 2024

No description provided.

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.94%. Comparing base (73aa8c0) to head (a1f635b).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #963      +/-   ##
============================================
+ Coverage     54.82%   55.94%   +1.11%     
- Complexity     1243     1268      +25     
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
+ Hits           4679     4774      +95     
+ Misses         3439     3327     -112     
- Partials        416      433      +17     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 57.39% <ø> (+3.34%) ⬆️
RocketMQ Proxy 37.28% <ø> (ø)
RocketMQ Store 73.65% <ø> (+0.04%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)
Files Coverage Δ
...com/automq/rocketmq/store/MessageStoreBuilder.java 0.00% <ø> (ø)
.../java/com/automq/rocketmq/store/S3StreamStore.java 0.00% <ø> (ø)

... and 18 files with indirect coverage changes

@daniel-y daniel-y merged commit 12016ce into main Apr 7, 2024
8 checks passed
@daniel-y daniel-y deleted the submodule_s3stream branch April 7, 2024 05:17
@daniel-y daniel-y restored the submodule_s3stream branch April 7, 2024 05:18
@daniel-y daniel-y deleted the submodule_s3stream branch April 7, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant