Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Graceful shutdown optimization #1578

Closed
CLFutureX opened this issue Jul 17, 2024 · 0 comments
Closed

[Enhancement] Graceful shutdown optimization #1578

CLFutureX opened this issue Jul 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@CLFutureX
Copy link
Contributor

CLFutureX commented Jul 17, 2024 •
edited
Loading

Background: When WAL (Write-Ahead Logging) is gracefully shut down, a significant number of write requests are directly interrupted.
com.automq.stream.s3.wal.impl.block.BlockWALService#shutdownGracefully

Optimization: Should we consider notifying the unfinished requests in real-time during the shutdown process? Especially when we view requests as listeners in the Observer pattern, it becomes even more crucial to send these notifications. One of the benefits of this approach is that it allows us to perceive the complete process of requests through logs or metrics.
@CLFutureX CLFutureX added the enhancement New feature or request label Jul 17, 2024
CLFutureX added a commit to CLFutureX/automq that referenced this issue Jul 17, 2024
@CLFutureX
feat(wal): graceful shutdown optimization (AutoMQ#1578)
39f9262
@CLFutureX CLFutureX mentioned this issue Jul 17, 2024
Merged
CLFutureX added a commit to CLFutureX/automq that referenced this issue Jul 18, 2024
@CLFutureX
feat(wal): graceful shutdown optimization (AutoMQ#1578)
4234bca
CLFutureX added a commit to CLFutureX/automq that referenced this issue Jul 18, 2024
@CLFutureX
feat(wal): graceful shutdown optimization (AutoMQ#1578)
44ba6fa
superhx pushed a commit that referenced this issue Jul 18, 2024
@CLFutureX
feat(wal): graceful shutdown optimization #1578 (#1579)
44df8ec 
* feat(wal): graceful shutdown optimization (#1578)

* feat(wal): graceful shutdown optimization (#1578)

* feat(wal): graceful shutdown optimization (#1578)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CLFutureX