feat(s3stream): add aws s3 rangeRead implementation for object storage #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warr99
requested review from
SCNieh,
ShadowySpirits and
Chillax-0v0
as code owners
superhx
reviewed
Jun 14, 2024
| boolean readWriteIsolate, | ||
| boolean checkS3ApiMode) { | ||
| this.bucket = bucket; | ||
| this.tagging = tagging(tagging); |
There was a problem hiding this comment.
Move bucket, tagging to AwsObjectStorage
superhx
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractObjectStorage.javaString pathin ReadTask has been replaced withS3ObjectMetadata s3ObjectMetadata.AwsObjectStorage.javais responsible for performing the rangeRead operations from S3,doRangeRead.