-
Notifications
You must be signed in to change notification settings - Fork 527
feat: integrate planning mode functionality across components #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate planning mode functionality across components #136
Conversation
SuperComboGamer
commented
Dec 17, 2025
- Added a new PlanningMode feature to manage default planning strategies for features.
- Updated the FeatureDefaultsSection to include a dropdown for selecting the default planning mode.
- Enhanced AddFeatureDialog and EditFeatureDialog to support planning mode selection and state management.
- Introduced PlanningModeSelector component for better user interaction with planning modes.
- Updated app state management to include default planning mode and related specifications.
- Refactored various UI components to ensure compatibility with new planning mode features.
- Added a new PlanningMode feature to manage default planning strategies for features. - Updated the FeatureDefaultsSection to include a dropdown for selecting the default planning mode. - Enhanced AddFeatureDialog and EditFeatureDialog to support planning mode selection and state management. - Introduced PlanningModeSelector component for better user interaction with planning modes. - Updated app state management to include default planning mode and related specifications. - Refactored various UI components to ensure compatibility with new planning mode features.
Summary of ChangesHello @SuperComboGamer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant new 'Planning Mode' feature, providing users with granular control over the AI agent's planning process for feature development. It integrates this functionality seamlessly across the application's UI, including feature creation/editing dialogs and user settings, while also updating the backend service to execute these varied planning strategies. The changes also include a substantial refactoring of Radix UI components for React 19 compatibility and the addition of a new select component. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant new "Planning Mode" feature and performs substantial refactoring of UI components for React 19 compatibility. The changes are well-structured and cover the frontend state management, UI dialogs, settings, and the backend service. The new PlanningModeSelector component is well-designed. The refactoring of Radix UI components is a great forward-looking improvement. I've identified a couple of minor maintainability issues concerning duplicated type definitions in the new frontend components, which I've detailed in the specific comments. Overall, this is a solid contribution.
| export type PlanningMode = 'skip' | 'lite' | 'spec' | 'full'; | ||
|
|
||
| export interface PlanSpec { | ||
| status: 'pending' | 'generating' | 'generated' | 'approved' | 'rejected'; | ||
| content?: string; | ||
| version: number; | ||
| generatedAt?: string; | ||
| approvedAt?: string; | ||
| reviewedByUser: boolean; | ||
| tasksCompleted?: number; | ||
| tasksTotal?: number; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PlanningMode and PlanSpec types are duplicated here. They are already defined and exported from app-store.ts. To maintain a single source of truth and avoid potential inconsistencies, please remove these local definitions and import them from @/store/app-store instead.
You should add the following import at the top of the file:
import { PlanningMode, PlanSpec } from '@/store/app-store';| SelectValue, | ||
| } from "@/components/ui/select"; | ||
|
|
||
| type PlanningMode = 'skip' | 'lite' | 'spec' | 'full'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PlanningMode type is duplicated here. It's already defined and exported from app-store.ts. To maintain a single source of truth, please remove this local type definition and import it from @/store/app-store.
You can add the import like this:
import type { PlanningMode } from '@/store/app-store';- Introduced PlanApprovalDialog for reviewing and approving feature plans. - Added state management for pending plan approvals and loading states. - Enhanced BoardView to handle plan approval actions, including approve and reject functionalities. - Updated KanbanCard and KanbanBoard components to include buttons for viewing and approving plans. - Integrated plan approval logic into the auto mode service, allowing for user feedback and plan edits. - Updated app state to manage default plan approval settings and integrate with existing feature workflows.
- Introduced TaskProgressPanel to display task execution status in the AgentOutputModal. - Enhanced useAutoMode hook to emit events for task start, completion, and phase completion. - Updated AutoModeEvent type to include new task-related events. - Implemented task parsing from generated specifications to track progress accurately. - Improved auto mode service to handle task progress updates and emit relevant events.