Skip to content

Conversation

@SuperComboGamer
Copy link
Collaborator

  • Added a new PlanningMode feature to manage default planning strategies for features.
  • Updated the FeatureDefaultsSection to include a dropdown for selecting the default planning mode.
  • Enhanced AddFeatureDialog and EditFeatureDialog to support planning mode selection and state management.
  • Introduced PlanningModeSelector component for better user interaction with planning modes.
  • Updated app state management to include default planning mode and related specifications.
  • Refactored various UI components to ensure compatibility with new planning mode features.

- Added a new PlanningMode feature to manage default planning strategies for features.
- Updated the FeatureDefaultsSection to include a dropdown for selecting the default planning mode.
- Enhanced AddFeatureDialog and EditFeatureDialog to support planning mode selection and state management.
- Introduced PlanningModeSelector component for better user interaction with planning modes.
- Updated app state management to include default planning mode and related specifications.
- Refactored various UI components to ensure compatibility with new planning mode features.
@SuperComboGamer SuperComboGamer added the Do Not Merge Use this label if something should not be merged. label Dec 17, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @SuperComboGamer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant new 'Planning Mode' feature, providing users with granular control over the AI agent's planning process for feature development. It integrates this functionality seamlessly across the application's UI, including feature creation/editing dialogs and user settings, while also updating the backend service to execute these varied planning strategies. The changes also include a substantial refactoring of Radix UI components for React 19 compatibility and the addition of a new select component.

Highlights

  • New Planning Mode Feature: Introduced a new PlanningMode functionality that allows users to define the level of upfront planning an AI agent performs before implementing features. This includes options from skipping planning entirely to generating comprehensive specifications requiring user approval.
  • UI Integration: The AddFeatureDialog and EditFeatureDialog components have been updated to support PlanningMode selection and state management. A new PlanningModeSelector component has been added for improved user interaction, and the 'Testing' tab in these dialogs has been renamed to 'Options' to accommodate this new feature.
  • Settings Configuration: The FeatureDefaultsSection in the settings view now includes a dropdown for selecting the default PlanningMode, allowing users to set their preferred planning strategy for new features.
  • State Management Updates: The application's state management (app-store.ts) has been updated to include defaultPlanningMode and PlanSpec types, ensuring that planning mode preferences and generated specifications are properly stored and managed.
  • Backend Service Enhancement: The AutoModeService on the server-side has been modified to incorporate planning mode prompts, enabling the AI agent to generate detailed plans or specifications based on the selected mode before proceeding with implementation.
  • Radix UI Component Refactoring: Several existing Radix UI components (Checkbox, Dialog, DropdownMenu, Popover, Slider, Tabs, Tooltip) have been refactored with type-safe wrappers to ensure compatibility with React 19 and improve code maintainability. A new @radix-ui/react-select component has also been added.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant new "Planning Mode" feature and performs substantial refactoring of UI components for React 19 compatibility. The changes are well-structured and cover the frontend state management, UI dialogs, settings, and the backend service. The new PlanningModeSelector component is well-designed. The refactoring of Radix UI components is a great forward-looking improvement. I've identified a couple of minor maintainability issues concerning duplicated type definitions in the new frontend components, which I've detailed in the specific comments. Overall, this is a solid contribution.

Comment on lines 12 to 23
export type PlanningMode = 'skip' | 'lite' | 'spec' | 'full';

export interface PlanSpec {
status: 'pending' | 'generating' | 'generated' | 'approved' | 'rejected';
content?: string;
version: number;
generatedAt?: string;
approvedAt?: string;
reviewedByUser: boolean;
tasksCompleted?: number;
tasksTotal?: number;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PlanningMode and PlanSpec types are duplicated here. They are already defined and exported from app-store.ts. To maintain a single source of truth and avoid potential inconsistencies, please remove these local definitions and import them from @/store/app-store instead.

You should add the following import at the top of the file:

import { PlanningMode, PlanSpec } from '@/store/app-store';

SelectValue,
} from "@/components/ui/select";

type PlanningMode = 'skip' | 'lite' | 'spec' | 'full';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PlanningMode type is duplicated here. It's already defined and exported from app-store.ts. To maintain a single source of truth, please remove this local type definition and import it from @/store/app-store.

You can add the import like this:

import type { PlanningMode } from '@/store/app-store';

- Introduced PlanApprovalDialog for reviewing and approving feature plans.
- Added state management for pending plan approvals and loading states.
- Enhanced BoardView to handle plan approval actions, including approve and reject functionalities.
- Updated KanbanCard and KanbanBoard components to include buttons for viewing and approving plans.
- Integrated plan approval logic into the auto mode service, allowing for user feedback and plan edits.
- Updated app state to manage default plan approval settings and integrate with existing feature workflows.
- Introduced TaskProgressPanel to display task execution status in the AgentOutputModal.
- Enhanced useAutoMode hook to emit events for task start, completion, and phase completion.
- Updated AutoModeEvent type to include new task-related events.
- Implemented task parsing from generated specifications to track progress accurately.
- Improved auto mode service to handle task progress updates and emit relevant events.
@SuperComboGamer SuperComboGamer changed the base branch from main to implement-planning/speckits-rebase December 18, 2025 02:44
@SuperComboGamer SuperComboGamer merged commit ecf34b1 into implement-planning/speckits-rebase Dec 18, 2025
@SuperComboGamer SuperComboGamer deleted the implement-planning/speckits branch December 18, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge Use this label if something should not be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants