Skip to content

terminals-mpve #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webdevcody merged 2 commits into from
Dec 20, 2025
Merged

terminals-mpve #172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37ce09e
Changes from terminals-mpve
webdevcody Dec 19, 2025
a84f2e5
Merge remote-tracking branch 'origin/main' into terminals-mpve
webdevcody Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 27 additions & 23 deletions apps/ui/src/components/layout/sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,12 +1029,6 @@ export function Sidebar() {
icon: UserCircle,
shortcut: shortcuts.profiles,
},
{
id: "terminal",
label: "Terminal",
icon: Terminal,
shortcut: shortcuts.terminal,
},
];

// Filter out hidden items
Expand All @@ -1048,29 +1042,39 @@ export function Sidebar() {
if (item.id === "profiles" && hideAiProfiles) {
return false;
}
if (item.id === "terminal" && hideTerminal) {
return false;
}
return true;
});

// Build project items - Terminal is conditionally included
const projectItems: NavItem[] = [
{
id: "board",
label: "Kanban Board",
icon: LayoutGrid,
shortcut: shortcuts.board,
},
{
id: "agent",
label: "Agent Runner",
icon: Bot,
shortcut: shortcuts.agent,
},
];

// Add Terminal to Project section if not hidden
if (!hideTerminal) {
projectItems.push({
id: "terminal",
label: "Terminal",
icon: Terminal,
shortcut: shortcuts.terminal,
});
}
Comment on lines +1049 to +1072
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved readability and conciseness, you can construct the projectItems array declaratively using conditional spreading. This avoids mutating the array after its creation and makes the logic more self-contained.

    const projectItems: NavItem[] = [
      {
        id: "board",
        label: "Kanban Board",
        icon: LayoutGrid,
        shortcut: shortcuts.board,
      },
      {
        id: "agent",
        label: "Agent Runner",
        icon: Bot,
        shortcut: shortcuts.agent,
      },
      ...(!hideTerminal
        ? [
            {
              id: "terminal",
              label: "Terminal",
              icon: Terminal,
              shortcut: shortcuts.terminal,
            },
          ]
        : []),
    ];


return [
{
label: "Project",
items: [
{
id: "board",
label: "Kanban Board",
icon: LayoutGrid,
shortcut: shortcuts.board,
},
{
id: "agent",
label: "Agent Runner",
icon: Bot,
shortcut: shortcuts.agent,
},
],
items: projectItems,
},
{
label: "Tools",
Expand Down