-
Notifications
You must be signed in to change notification settings - Fork 493
chore(docker): add Playwright Chromium prerequisites #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,9 +8,17 @@ | |
| FROM node:22-slim | ||
|
|
||
| # Install build dependencies for native modules (node-pty) and runtime tools | ||
| # Also install Playwright/Chromium system dependencies (aligns with playwright install-deps on Debian/Ubuntu) | ||
| RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
| python3 make g++ \ | ||
| git curl bash gosu ca-certificates openssh-client \ | ||
| # Playwright/Chromium dependencies | ||
| libglib2.0-0 libnss3 libnspr4 libdbus-1-3 libatk1.0-0 libatk-bridge2.0-0 \ | ||
| libcups2 libdrm2 libxkbcommon0 libatspi2.0-0 libxcomposite1 libxdamage1 \ | ||
| libxfixes3 libxrandr2 libgbm1 libasound2 libpango-1.0-0 libcairo2 \ | ||
| libx11-6 libx11-xcb1 libxcb1 libxext6 libxrender1 libxss1 libxtst6 \ | ||
| libxshmfence1 libgtk-3-0 libexpat1 libfontconfig1 fonts-liberation \ | ||
| xdg-utils libpangocairo-1.0-0 libpangoft2-1.0-0 libu2f-udev libvulkan1 \ | ||
|
Comment on lines
+16
to
+21
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For better readability and maintainability, it's good practice to sort this package list alphabetically. Additionally, this list of dependencies is now duplicated between |
||
| && GH_VERSION="2.63.2" \ | ||
| && ARCH=$(uname -m) \ | ||
| && case "$ARCH" in \ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and maintainability, it's good practice to sort package lists alphabetically. This makes it easier to see what's included and to spot duplicates or missing packages in the future.