fix(ui): bulk update cache invalidation and model dropdown display#633
fix(ui): bulk update cache invalidation and model dropdown display#633stefandevo merged 1 commit intov0.13.0rcfrom
Conversation
Fix two related issues with bulk model updates in Kanban view: 1. Bulk update now properly invalidates React Query cache - Changed handleBulkUpdate and bulk verify handler to call loadFeatures() - This ensures UI immediately reflects bulk changes 2. Custom provider models (GLM, MiniMax, etc.) now display correctly - Added fallback lookup in PhaseModelSelector by model ID - Updated mass-edit-dialog to track providerId after selection
Summary of ChangesHello @stefandevo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses two key UI issues to improve user experience. Firstly, it ensures that bulk updates in the Kanban board are immediately reflected in the UI by properly invalidating the React Query cache. Secondly, it resolves a display problem where custom AI models from various providers were not showing up correctly in the model selection dropdown after being chosen, making the model selection process more reliable. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughWalkthroughBulk operation handling in board-view is refactored to refetch server data instead of local mutations. MassEditDialog now tracks providerId state. PhaseModelSelector adds fallback logic for Claude-compatible models when providerId is undefined. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
The pull request effectively addresses two key UI issues: ensuring immediate UI updates after bulk operations by invalidating the React Query cache, and correctly displaying custom provider models in dropdowns. The changes are well-implemented, leveraging React Query for data consistency and adding necessary logic to handle provider-specific model display. The code is clean and follows good practices.
Summary
Changes
React Query Cache Invalidation
handleBulkUpdateand bulk verify handler to callloadFeatures()instead of manually updating Zustand storeCustom Provider Model Display
PhaseModelSelectorthat searches for provider models by model ID even whenproviderIdis not setmass-edit-dialog.tsxto trackproviderIdafter selection so the dropdown displays correctlyTest plan
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.