fix: Remove mandatory Claude check for Project Settings -> Models#686
Conversation
Summary of ChangesHello @Monoquark, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where the Project Settings -> Models page was inaccessible if the Claude AI provider was disabled. The changes remove the dependency on Claude's availability for this specific UI section, allowing users to manage project model overrides even when Claude is not configured or other providers are in use. This significantly improves the flexibility and usability of the project settings by ensuring consistent access to model configuration. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughRemoved the Claude availability guard and related UI branch; added JSDoc, model display-name resolution improvements, and project-level set/clear override handlers; preserved Bulk Replace and Reset actions and kept the hasEnabledProviders check; added minor state for the Bulk Replace dialog and per-project override counting. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request correctly removes the mandatory check for the Claude AI provider on the "Project Settings -> Models" page. This fixes a bug where the page was inaccessible if the Claude provider was disabled, even when other providers were available. The change is straightforward and effective. I've added a minor suggestion to clean up an unused variable that resulted from this change.
apps/ui/src/components/views/project-settings-view/project-models-section.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Disabling the Claude AI provider blocked the Project Settings -> Models page, even though it is not needed there and other providers can be used. The UI even works with no providers enabled.
This fix allows access to the page irrespective of the enabled AI providers.
Summary by CodeRabbit
Bug Fixes
Features
Refactor
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.