Skip to content

fix: Remove mandatory Claude check for Project Settings -> Models#686

Merged
Shironex merged 3 commits intoAutoMaker-Org:v0.14.0rcfrom
Monoquark:fix/resolve-claude-required-model-settings
Jan 25, 2026
Merged

fix: Remove mandatory Claude check for Project Settings -> Models#686
Shironex merged 3 commits intoAutoMaker-Org:v0.14.0rcfrom
Monoquark:fix/resolve-claude-required-model-settings

Conversation

@Monoquark
Copy link
Contributor

@Monoquark Monoquark commented Jan 24, 2026

Disabling the Claude AI provider blocked the Project Settings -> Models page, even though it is not needed there and other providers can be used. The UI even works with no providers enabled.

This fix allows access to the page irrespective of the enabled AI providers.

Summary by CodeRabbit

  • Bug Fixes

    • Fixed override count to correctly include both per-phase overrides and the default feature model override.
  • Features

    • Removed a provider-specific "not configured" notice so the models section shows fewer blocking messages; Bulk Replace and Reset remain available when providers are enabled.
  • Refactor

    • Simplified provider availability checks in the models UI.
  • Documentation

    • Added inline documentation clarifying display name resolution, override behavior, and phase/group rendering.

✏️ Tip: You can customize this high-level summary in your review settings.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Monoquark, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the Project Settings -> Models page was inaccessible if the Claude AI provider was disabled. The changes remove the dependency on Claude's availability for this specific UI section, allowing users to manage project model overrides even when Claude is not configured or other providers are in use. This significantly improves the flexibility and usability of the project settings by ensuring consistent access to model configuration.

Highlights

  • Removed Mandatory Claude Check: The mandatory check for the Claude AI provider on the Project Settings -> Models page has been removed. Previously, disabling Claude would block access to this page, even if other AI providers were available or no providers were enabled.
  • Improved UI Accessibility: The Project Settings -> Models page is now accessible regardless of the enabled AI providers, ensuring users can configure model overrides without being restricted by the status of a single provider.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 24, 2026

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

Removed the Claude availability guard and related UI branch; added JSDoc, model display-name resolution improvements, and project-level set/clear override handlers; preserved Bulk Replace and Reset actions and kept the hasEnabledProviders check; added minor state for the Bulk Replace dialog and per-project override counting.

Changes

Cohort / File(s) Summary
Project Models UI
apps/ui/src/components/views/project-settings-view/project-models-section.tsx
Added JSDoc for helper functions and components; implemented handleClearOverride and handleSetOverride; enhanced getModelDisplayName to prefer provider metadata and aliases; removed isClaudeDisabled and the "Claude not configured" UI branch and disabledProviders usage; retained hasEnabledProviders guard for Bulk Replace; added phaseOverrideCount and small Bulk Replace dialog state.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 I hopped into the settings glade,
Cleared a guard that once would fade,
Named the models, set and wiped,
Bulk dialogs primed, counts type-sniped,
I nibble bugs and leave code made.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: removing the Claude availability check from the Project Settings Models page.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the mandatory check for the Claude AI provider on the "Project Settings -> Models" page. This fixes a bug where the page was inaccessible if the Claude provider was disabled, even when other providers were available. The change is straightforward and effective. I've added a minor suggestion to clean up an unused variable that resulted from this change.

Monoquark and others added 2 commits January 24, 2026 21:37
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Shironex Shironex added Bug Something isn't working scope: ui UI/UX changes, layout, visual or interaction behavior. labels Jan 25, 2026
@Shironex Shironex merged commit 74b301c into AutoMaker-Org:v0.14.0rc Jan 25, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working scope: ui UI/UX changes, layout, visual or interaction behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants