Skip to content

Improve pull request prompt and generation handling #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gsxdsm merged 2 commits into from
Feb 22, 2026
Merged

Improve pull request prompt and generation handling #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f29251d
Changes from fix/improve-pull-request-prompt
gsxdsm Feb 22, 2026
fad8bac
Update apps/ui/src/components/views/board-view/dialogs/create-pr-dial…
gsxdsm Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/server/src/routes/worktree/routes/generate-pr-description.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ Rules:
- Focus on the user-facing impact when possible
- If there are breaking changes, mention them prominently
- The diff may include both committed changes and uncommitted working directory changes. Treat all changes as part of the PR since uncommitted changes will be committed when the PR is created
- Do NOT distinguish between committed and uncommitted changes in the output - describe all changes as a unified set of PR changes`;
- Do NOT distinguish between committed and uncommitted changes in the output - describe all changes as a unified set of PR changes
- EXCLUDE any files that are gitignored (e.g., node_modules, dist, build, .env files, lock files, generated files, binary artifacts, coverage reports, cache directories). These should not be mentioned in the description even if they appear in the diff
- Focus only on meaningful source code changes that are tracked by git and relevant to reviewers`;
Comment on lines +57 to +58
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the changes in libs/prompts/src/defaults.ts, consider combining these two rules into a single, more concise instruction. This also improves prompt efficiency.

For example:

- Ignore changes to gitignored files (e.g., node_modules, dist, build, .env files, lock files, generated files, binary artifacts, coverage reports, cache directories). Focus only on meaningful source code changes that are tracked by git and relevant to reviewers.


/**
* Wraps an async generator with a timeout.
Expand Down
6 changes: 3 additions & 3 deletions apps/ui/src/components/views/board-view/dialogs/create-pr-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ export function CreatePRDialog({

return (
<Dialog open={open} onOpenChange={handleClose}>
<DialogContent className="sm:max-w-[550px]">
<DialogContent className="sm:max-w-[550px] flex flex-col">
<DialogHeader>
<DialogTitle className="flex items-center gap-2">
<GitPullRequest className="w-5 h-5" />
Expand Down Expand Up @@ -565,7 +565,7 @@ export function CreatePRDialog({
</div>
) : (
<>
<div className="grid gap-4 py-4">
<div className="grid gap-4 py-4 overflow-y-auto min-h-0 flex-1">
{worktree.hasChanges && (
<div className="grid gap-2">
<Label htmlFor="commit-message">
Expand Down Expand Up @@ -739,7 +739,7 @@ export function CreatePRDialog({
{error && <p className="text-sm text-destructive">{error}</p>}
</div>

<DialogFooter>
<DialogFooter className="shrink-0 pt-2 border-t">
<Button variant="ghost" onClick={handleClose} disabled={isLoading}>
Cancel
</Button>
Expand Down
1 change: 1 addition & 0 deletions libs/prompts/src/defaults.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,7 @@ Rules:
- Focus on WHAT changed and WHY (if clear from the diff), not HOW
- No quotes, backticks, or extra formatting
- If there are multiple changes, provide a brief summary on the first line
- Ignore changes to gitignored files (e.g., node_modules, dist, build, .env files, lock files, generated files, binary artifacts, coverage reports, cache directories). Focus only on meaningful source code changes that are tracked by git

Examples:
- feat: Add dark mode toggle to settings
Expand Down