Make the C# object disposable #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrapper user can decide to release the native handle immediately to avoid potential resource race issues.
martinweismann
previously approved these changes
Apr 4, 2022
martinweismann
approved these changes
Apr 5, 2022
martinweismann
pushed a commit
to martinweismann/AutomaticComponentToolkit
that referenced
this pull request
Aug 24, 2022
* Make C# object with native handle disposable The wrapper user can decide to release the native handle immediately to avoid potential resource race issues. * Implement dispose pattern following the Microsoft documentation https://docs.microsoft.com/en-us/dotnet/standard/garbage-collection/implementing-dispose * Refine the change according to pull request comments Co-authored-by: Kevin Zhang <Ping.Zhang@autodesk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the Microsoft documentation to implement dispose
https://docs.microsoft.com/en-us/dotnet/standard/garbage-collection/implementing-dispose
@martinweismann PTAL.