Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tags defined #9

Open
rjbell4 opened this issue Mar 22, 2017 · 3 comments
Open

No tags defined #9

rjbell4 opened this issue Mar 22, 2017 · 3 comments

Comments

@rjbell4
Copy link
Contributor

rjbell4 commented Mar 22, 2017

The version.sh now returns a version based on a tag, but there aren't any tags defined in this public repository

Suggestions:

Note that this still won't work for us, as we typically build on top of these releases. I may change our version.sh to instead search for the most recent version referenced by the HEAD commit.

@rjbell4
Copy link
Contributor Author

rjbell4 commented Mar 23, 2017

I think I'm going to add the tags as indicated above, and then use git describe --always --tags --dirty instead of the version number and hash

@larsxschneider
Copy link
Contributor

You are right! I must admit I neglected the open source version here a bit... just too many things to do ! Internally we are in 1.5.x already. Are you using this tool in production, too? If yes, then I would love to chat with you!

@rjbell4
Copy link
Contributor Author

rjbell4 commented Mar 23, 2017

Yes, we are using it in production. I have a few tweaks I've made that you could use, and a few that you wouldn't. Someone else initially pulled it in, but didn't manage it particularly well, so I'm sort of taking over. I'm completely willing to chat sometime.

ballab1 pushed a commit to ballab1/enterprise-config-for-git that referenced this issue Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants