Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAYA-111092] Reference USD not using namespaces #1307

Closed
ghostvfx-jimmy opened this issue Apr 6, 2021 · 17 comments
Closed

[MAYA-111092] Reference USD not using namespaces #1307

ghostvfx-jimmy opened this issue Apr 6, 2021 · 17 comments
Assignees
Labels
bug Something isn't working reproduced Issue has been reproduced

Comments

@ghostvfx-jimmy
Copy link
Contributor

Describe the bug
When creating a USD reference, namespaces are not applied.

Steps to reproduce
Steps to reproduce the behavior:

  1. Create reference..
  2. Enable "Use namespaces"
  3. Select a USD file and chose "Reference"
  4. Reference created without namespace.

Expected behavior
When creating a reference with "Use namespaces" enabled, it's expected that it's with namespace.

Specs (if applicable):

  • Linux
  • Maya 2020.4
  • Maya USD v0.8.0 (release from this site)
@ghostvfx-jimmy ghostvfx-jimmy added the bug Something isn't working label Apr 6, 2021
@santosd
Copy link
Collaborator

santosd commented Apr 6, 2021

Hello @ghostvfx-jimmy, I gave this a try on my end and I was not able to reproduce the issue you are seeing. When I follow those same steps and use the namespace option to use the file name, I see a namespace created with the file name. If I use the option for a string, it uses the string I specify. In both instances I can open the Namespace Editor and verify that a new namespace is created.

@santosd santosd self-assigned this Apr 6, 2021
@ghostvfx-jimmy
Copy link
Contributor Author

Yes, the namespace is created but the objects within the reference is not using the namespace.

Eg.:
If you import sphere.usd with pSphere1 object twice, the second import will rename the object to pSphere2. Normally it would be called sphere:pSphere1 and sphere1:pSphere1.

Also even if the namespace is created, using the namespace editor > Select Content doesn't work for the USD reference.

@santosd
Copy link
Collaborator

santosd commented Apr 8, 2021

@ghostvfx-jimmy Thank you for clarifying that for me. I definitely see the issue now. I will mark this issue as reproduced and will review it with the team to see about getting a fix going for it.

@santosd santosd added the reproduced Issue has been reproduced label Apr 8, 2021
@santosd santosd removed their assignment Apr 8, 2021
@santosd santosd changed the title Reference USD not using namespaces [MAYA-111092] Reference USD not using namespaces Apr 20, 2021
@ghostvfx-jimmy
Copy link
Contributor Author

Any updates on this? It's a rather big roadblock for us before we can go all USD..

@santosd
Copy link
Collaborator

santosd commented Oct 20, 2021

Hi @ghostvfx-jimmy, We have the issue logged internally and scheduled for a fix, but it has not been fixed at this point.

@Xaia
Copy link

Xaia commented Dec 9, 2021

hi @santosd any update on this issue? It's a quite big show stopper. Would love to see that fixed :)

@santosd
Copy link
Collaborator

santosd commented Dec 9, 2021

Hello @Xaia, This issue is still in our backlog and has not been fixed internally. I will bring it up to the team to let them know that this is a showstopper for you so that we can set it at a higher priority.

@santosg87 santosg87 assigned santosd and unassigned santosg87 Jan 17, 2022
@santosd
Copy link
Collaborator

santosd commented Feb 7, 2022

Hi @Xaia there was a change that went in recently that seems to have fixed this issue on my end. Would you be able to build the latest and test again? Otherwise we can wait until the next release and you can test at that point to see if it is working for you
namespaceReference
.

@ghostvfx-jimmy
Copy link
Contributor Author

ghostvfx-jimmy commented Feb 14, 2022

I hate to break it to you, but the clip actually shows the bug. The issue is not wether or not it's getting a reference group, but the fact that the referenced geometry is not assigned a namespace prefix. This means that a second import will change the name of the object (adding a suffix).

So instead of just being named pPlane13 it should have been called ColorTest:pPlane13

@santosd
Copy link
Collaborator

santosd commented Feb 14, 2022

Hi @ghostvfx-jimmy, I do see that. It looks like there was a little more support added for namespaces but we are not fully there yet. The ticket we have logged internally remains open and we will be taking a look at the issue.

@jacobvfx
Copy link

jacobvfx commented Apr 7, 2022

Any progress on this issue?

It's a big roadblock moving forward with USD in Maya.
It breaks the normal convention of what a Maya Reference is and doesn't match the behavior you get when loading in a ma/mb or alembic file.

@santosd
Copy link
Collaborator

santosd commented Apr 8, 2022

Hi @jacobvfx,
No updates on this as of yet. We have the issue scheduled to be worked on for an upcoming release so hopefully we are able to work on this soon. I will be sure to let the team know that this is an adoption blocker for a lot of users.

@ppt-adsk
Copy link
Collaborator

Hello @jacobvfx, @Xaia, @ghostvfx-jimmy. Bug is fixed here:
#2308
Trivial fix in the end, but which ended up revealing another problem: this behavior (import not supporting namespaces) has been here since the beginning of the Pixar Maya USD plugin, was copied over to the Autodesk plugin, and its effect has been incorporated into maya-usd automated tests (which I have fixed).

We are concerned that some users of maya-usd import are actually relying on the bug, and assuming imported nodes won't be in a namespace. Of course, these users should actually fix their code and not ask for namespace support, but we want to make sure we aren't disruptive in fixing this bug, and don't require mitigating measures e.g. like an environment variable to preserve the legacy (buggy) behavior.

My personal preference is to do this cleanly, fix the bug, adjust the broken tests, which is what I have done, and I hope that maya-usd users will do the same. Is this a reasonable way to proceed? Your opinions quite welcome.

@daviddeacon
Copy link

I agree in fixing cleanly and not worry about users that rely on the code bug. Just make sure the change is mentioned in the release notes.

It’s an in alpha for a reason.

@cescocm
Copy link

cescocm commented Apr 27, 2022

Hi, @ppt-adsk I also agree that being these versions are still in development any integration can assume these types of bug fixes. And users that are actually relying on the bug, and assuming imported nodes won't be in a namespace can easily have their wanted behaviour back as long as they are informed of the change so they can react.

I think that it would be completely inconsistent to do this in a different way (environment variables, making the default being not namespace, or whatever this might be that is not matching the normal behaviour for all the other formats).

My 2 cents.

@ppt-adsk
Copy link
Collaborator

Merged to dev branch here:
89ae0a7
Thanks for your feedback!

@santosg87
Copy link
Collaborator

based on the comments above and the commits, i believe this can now be closed.

feel free to reopen/log a new issue if there are problems with this still.

@neilh-adsk neilh-adsk moved this to Done in maya-usd Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reproduced Issue has been reproduced
Projects
Archived in project
Development

No branches or pull requests

8 participants