install and remove UsdMayaDiagnosticDelegate for adsk plugin load and unload #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lugins This adds an installation count that is used to determine whether to construct or destroy the shared UsdMayaDiagnosticDelegate when multiple calls to the static InstallDelegate() and RemoveDelegate() functions are made. This ensures that only a single instance of the delegate is installed when for example both the "pxrUsd" and "mayaUsdPlugin" Maya plugins are loaded, and that the delegate is not removed until both plugins are unloaded. The installation counter follows a similar pattern to the one used for MayaUsdProxyShapePlugin.
It turns out that the absence of UsdMayaDiagnosticDelegate when using the mayaUsdPlugin was the reason that the full error message was being suppressed. Now that mayaUsdPlugin installs the delegate as well, we can test for the correct error message.
kxl-adsk
approved these changes
Dec 15, 2020
kxl-adsk
added
the
ready-for-merge
mattyjams
deleted the
pr/install_and_remove_diagnostic_delegate_for_adsk_plugin_load_and_unload
branch
ysiewappl
added a commit
to dgovil/maya-usd
that referenced
this pull request
Dec 17, 2020
ysiewappl
added a commit
to dgovil/maya-usd
that referenced
this pull request
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make
mayaUsdPluginuseUsdMayaDiagnosticDelegatein the same way that thepxrUsdplugin currently does. The delegate's install and remove functions were modified slightly to make this work, using a pattern similar to the one used forMayaUsdProxyShapePlugin.The diagnostic delegate takes care of intercepting messages emitted by the
Tflibrary in core USD and relaying them to the appropriateMGlobalfunctions (e.g.displayWarning(),displayError(), etc.).This should address an issue @ysiewappl ran into in #952 where it was necessary to explicitly call both diagnostic functions with the same message:
https://github.com/Autodesk/maya-usd/pull/952/files#r539582025
It also turns out that this fixes an issue @ppt-adsk ran into where the full error message in Python exceptions was not making it through in the
testUsdExportStripNamespacestest.