Fix texture writer path resolver to work relative to final export path #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgovil
force-pushed
the
resolve_final_filename_issue972
branch
from
a3450b4 to
63d63f4
Compare
|
Oops, missed some arnold attributes when cleansing the maya file. Updated PR with those removed. |
mattyjams
suggested changes
Jan 4, 2021
There was a problem hiding this comment.
The changes make sense to me, but I think we want to try to keep the userArgs dictionary in a state where it contains the exact arguments the user passed in. I had a suggestion of adding a new public method to UsdMayaJobExportArgs that would hopefully make that work. Let me know what you think!
…h rather than any temp paths the exporter sets. Address Autodesk#972
dgovil
force-pushed
the
resolve_final_filename_issue972
branch
from
63d63f4 to
dcd4094
Compare
JGamache-autodesk
approved these changes
Jan 5, 2021
dgovil
force-pushed
the
resolve_final_filename_issue972
branch
from
dcd4094 to
ab1aece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the texture writer in the exporter expects the stage being written to be the final export path.
.usdzfiles however switch the exporter to write to a temporary location. Therefore prim writers etc do not have access to the final path for their logic. This change makes it so that the fileName is part of the export args, to be available to the rest of the exporter code base.This addresses the issue in #972 and should make usdz exports once again compatible with AR QuickLook on iOS, and preview on Mac.
Also I realize everyone is on, or will be on, holiday break, so no rush on responding to this PR. I just wanted to post it before our break starts too. Hope everyone has a great holiday season.