Fix for UFE v1 code path with missing "|world". #1050
Conversation
seando-adsk
added
bug
| // with "|world" and will pop it off. So make sure our string has it. | ||
| // Note: std::string starts_with only added for C++20. So use diff trick. | ||
| std::string proxyPath; | ||
| if (ufePathString.rfind("|world", 0) == std::string::npos) { |
|
@mattyjams I added to you review the change I made to test/lib/ufe/testUfePythonImport.py |
| #ifdef UFE_V2_FEATURES_AVAILABLE | ||
| def("getPrimFromRawItem", getPrimFromRawItem); | ||
| def("getNodeNameFromRawItem", getNodeNameFromRawItem); | ||
| #endif | ||
|
|
||
| def("getNodeTypeFromRawItem", getNodeTypeFromRawItem); | ||
| #endif |
There was a problem hiding this comment.
The raw item (for ufe scene item) was only added in UFE v2. So these three wrappers that use raw item should only be avail in v2.
| ''' Called initially to set up the Maya test environment ''' | ||
| self.assertTrue(self.pluginsLoaded) | ||
|
|
||
| def testWrappers(self): |
There was a problem hiding this comment.
New test where I test all the maya-usd ufe wrapper methods.
test/lib/ufe/testUfePythonImport.py
Outdated
| if ufe.VersionInfo.getMajorVersion() >= 2: | ||
| # raw item only introduced in UFE v2 | ||
| invalidPrim = mayaUsdUfe.getPrimFromRawItem(0) | ||
| else: | ||
| # In UFE v2 if the Nb segments == 1, returns invalid prim | ||
| invalidPrim = mayaUsdUfe.ufePathToPrim('a') |
There was a problem hiding this comment.
This test is avail in UFE v1, but it was using a ufe wrapper method that I've made only avail in UFE v2. So for the v1 case use a different wrapper method. We cannot just use ufePathToPrim for both UFE versions, since in UFE v2 ufePathToPrim uses different code that will assert with an invalid input path.
| @@ -23,6 +23,7 @@ | |||
| import mayaUsd.ufe | |||
|
|
|||
| import ufe | |||
| import ufeUtils | |||
There was a problem hiding this comment.
Oops I forgot to include this to have access for line 45. Since this usd utils already includes ufe, including the ufeUtils should be okay.
seando-adsk
added
the
ready-for-merge
No description provided.