Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed anonymous layer import #1086

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Conversation

kxl-adsk
Copy link

Reported in #1069. We didn't have symmetry between import and export behavior for anonymous layers.

It may be confusing that we are using a file path to feed layer identifier, but since the exporter and the underlying job already handles it we filter out anonymous layers when validating the path provided.

@kxl-adsk kxl-adsk added the import-export Related to Import and/or Export label Jan 17, 2021
Copy link
Contributor

@mattyjams mattyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kxl-adsk kxl-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Jan 21, 2021
@kxl-adsk kxl-adsk merged commit d673c6d into dev Jan 21, 2021
@kxl-adsk kxl-adsk deleted the kxl-adsk/fix_anonymous_layer_import branch January 21, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
import-export Related to Import and/or Export ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants