author kind=group on the UsdPrim created by the group command when its parent is in the model hierarchy #1094
Conversation
…arent is in the model hierarchy Authoring the kind metadata on the group Xform prim ensures that the model hierarchy remains contiguous. Prims underneath the group prim may still be in the model hierarchy if they also have kind authored. If the parent prim of the group prim is not part of the model hierarchy, no kind is authored on the group prim.
| UsdUndoSetKindCommand(const UsdUndoSetKindCommand&) = delete; | ||
| UsdUndoSetKindCommand& operator=(const UsdUndoSetKindCommand&) = delete; | ||
| UsdUndoSetKindCommand(UsdUndoSetKindCommand&&) = delete; | ||
| UsdUndoSetKindCommand& operator=(UsdUndoSetKindCommand&&) = delete; |
There was a problem hiding this comment.
I see we copy this pattern around making the declaration of this trivial class busier than it has to be.
The base class Ufe::UndoableCommand already explicitly deletes the copy constructor. This will make the compiler implicitly delete any derived class copy constructors. So line 41 is not needed.
Lack of a copy constructor will also make the compiler implicitly delete the move constructor. So line 43 is not needed.
Finally, we should do a better job in the base class and delete the copy assignment operator, this would make the compiler implicitly delete the copy assignment operator and move the assignment operator from the derived class. This is not currently done, so lines 42 and 44 have to stay.
There was a problem hiding this comment.
That's a good point. I really don't have a strong opinion here. I personally am not a huge fan of implicit philosophy whether it is C++ or any other languages.
kxl-adsk
added
the
ready-for-merge
mattyjams
deleted the
pr/author_group_kind_when_grouping_in_model_hierarchy
branch
Authoring the kind metadata on the group
Xformprim ensures that the model hierarchy remains contiguous between the parent and children of the new group prim. Prims underneath the group prim may still be in the model hierarchy if they also have kind authored.If the parent prim of the group prim is not part of the model hierarchy, no kind is authored on the group prim.
More info about model hierarchy can be found here:
https://graphics.pixar.com/usd/docs/USD-Glossary.html#USDGlossary-ModelHierarchy