header include fixes for refactoring_sandbox branch #11
Conversation
* Enable generating compile_commands.json by default * Make sure the build and install folders have the variant * Fix typo in ReadMe
* temporarily revert line endings to windows to do merge * standardize on linux-style line endings (newline only)
these fall into 3 categories: - adding USD_INCLUDE_DIR (similar to what was done on master branch) - correcting relative path for schemas ...possibly this was moved recently? - changing paths in hdMaya to use "../foo.h" syntax instead of <../foo.h> for relative paths; this may be a difference in how Visual-C++ handles this versus gcc
|
We have recently made several new improvements in our internal refactoring_sandbox which we are planning to push to public very soon. Category 2,3 are already in our internal refactoring_sandbox branch. We are trying to understand category 1 before applying your change. I hope you are Ok if we close this PR? |
|
In general, I would argue for not closing a PR that has necessary fixes, until those fixes have been addressed in the publicly available branch - both because it serves as a todo / reminder that a fix needs to be pushed, and because it provides a necessary workaround for others until the internal fix is made public. Technically, the workaround is still accessible if the PR is closed, but it becomes much less visible. |
…07-19 Support Draco USDZ archives, check property opinions.
|
Since category 1 should have been addressed by the USD cmake changes @mattyjams made (and it should be safe to say that the refactoring_sandbox branch should use a new USD), and the other two are addressed in this repo, I'm closing this PR |
these fall into 3 categories:
...possibly this was moved recently?
for relative paths; this may be a difference in how Visual-C++ handles
this versus gcc