Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAYA-109928: Remove dependency on Boost chrono and date_time. #1184

Merged
merged 2 commits into from
Feb 25, 2021
Merged

MAYA-109928: Remove dependency on Boost chrono and date_time. #1184

merged 2 commits into from
Feb 25, 2021

Conversation

HamedSabri-adsk
Copy link
Contributor

This PR removes the dependency on Boost chrono and date_time in AL plugin.

When Building USD, --with-date_time no longer needs to be passed.

@HamedSabri-adsk HamedSabri-adsk changed the title Remove dependency on Boost chrono and date_time. MAYA-109928: Remove dependency on Boost chrono and date_time. Feb 16, 2021
@HamedSabri-adsk HamedSabri-adsk added the core Related to core library label Feb 16, 2021
@HamedSabri-adsk HamedSabri-adsk mentioned this pull request Feb 17, 2021
Merged
@kxl-adsk kxl-adsk requested a review from fabal February 23, 2021 20:41
kxl-adsk
kxl-adsk approved these changes Feb 23, 2021
View reviewed changes
Copy link

@kxl-adsk kxl-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense to me, but since it impacts the AL plugin, let's give @fabal chance to comment on it.

fabal
fabal approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@fabal fabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HamedSabri-adsk 👍

@kxl-adsk
Copy link

@HamedSabri-adsk please resolve merge conflicts and mark for merge when ready.

@HamedSabri-adsk HamedSabri-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Feb 24, 2021
@kxl-adsk kxl-adsk merged commit 6f9031f into dev Feb 25, 2021
@kxl-adsk kxl-adsk deleted the sabrih/MAYA-109928/remove_boost_date_chrono branch February 25, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabal fabal fabal approved these changes

@kxl-adsk kxl-adsk kxl-adsk approved these changes

Assignees

@ecp-maya-devops-adsk ecp-maya-devops-adsk

Labels
core Related to core library ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HamedSabri-adsk @kxl-adsk @fabal @ecp-maya-devops-adsk