MAYA-107276 - As a user, on the stage AE template I'd like to use Pri… #1189

spinell-adsk · 2021-02-17T19:15:33Z

…m Path

-Add Prim Path field in attribute editor
-Use the prime path to render with VP2RenderDelegate
-Change prim path tooltip

…m Path -Add Prim Path field in attribute editor -Use the prime path to render with VP2RenderDelegate -Change prim path tooltip

seando-adsk · 2021-02-18T14:39:35Z

plugin/adsk/scripts/AEmayaUsdProxyShapeTemplate.mel

@@ -39,7 +39,7 @@ global proc AEmayaUsdProxyShapeTemplate( string $nodeName )
        editorTemplate -suppress "outStageCacheId";

        // MAYA-109438 - temp suppress these non-functional attributes.
-        editorTemplate -suppress "primPath";
+        //editorTemplate -suppress "primPath";


Let's just remove this line.

spinell-adsk · 2021-02-18T15:07:16Z

Please do not merge yet. I found 2 issues that I need to fix.
The first one is the primPath feature does not work as expected when the stage is create in memory.
The second one is when using primPath, the transform matrix use for rendering is wrong.

…m Path -Fix transform issue when using primPath -Move primPathAttr dependacy with inStageDataCachedAttr from ProxyShapeBase to ProxyShape to avoid issue when when primPath is dirty (stage in memory get cleared)

# Conflicts: # plugin/adsk/scripts/AEmayaUsdProxyShapeTemplate.mel

# Conflicts: # plugin/adsk/scripts/AEmayaUsdProxyShapeBaseTemplate.mel

spinell-adsk

@mattyjams I moved the dependency between primPathAttr and inStageDataCachedAttr from ProxyShapeBase to ProxyShape
because we are currently have issue when the primPath changed. When we are re-computing the stage cache, if the stage is not found in a file (stage created in memory) we are creating a new in memory stage which override the current one.

Do you have any concern about this change ?

spinell-adsk · 2021-02-22T17:51:52Z

lib/mayaUsd/nodes/proxyShapeBase.cpp

@@ -387,8 +387,6 @@ MStatus MayaUsdProxyShapeBase::initialize()
    retValue = attributeAffects(filePathAttr, outStageCacheIdAttr);
    CHECK_MSTATUS_AND_RETURN_IT(retValue);

-    retValue = attributeAffects(primPathAttr, inStageDataCachedAttr);


Moved the dependency in subclass ProxyShape.
Having this dependency in proxyShapeBase cause issue when using a primPath with a stage that is created in memory.
When computing the inStageDataCachedAttr, when the stage is create in memory, a new stage is created and everything is lost.

It's worth mentioning why this dependency doesn't belong to the base class - when computing inStageDataCachedAttr, there is nothing that reads primPathAttr unless we are calling into computeSessionLayer implementation of pxr proxy shape - https://github.com/Autodesk/maya-usd/blob/dev/plugin/pxr/maya/lib/usdMaya/proxyShape.cpp#L189

There is still the unwanted effect of clearing the stage on a change to the prim path with pxr proxy shape, but assembly workflows were not working with in-memory stages.

…m Path Fix clang format

kxl-adsk

Mostly looks good to me. I think it would be worth saving on matrix multiplication when prim path is not the default.
Additionally, this is something we would like to have a regression test for and make sure we don't regress - please check https://github.com/Autodesk/maya-usd/blob/dev/test/lib/mayaUsd/render/vp2RenderDelegate/testVP2RenderDelegatePointInstanceSelection.py for an example of such a test.

kxl-adsk · 2021-02-24T09:57:27Z

lib/mayaUsd/render/vp2RenderDelegate/proxyRenderDelegate.cpp

+    const UsdTimeCode timeCode = _proxyShapeData->ProxyShape()->getTime();
+    UsdGeomXformCache xformCache(timeCode);
+    GfMatrix4d m = xformCache.GetLocalToWorldTransform(_proxyShapeData->ProxyShape()->usdPrim());
+    transform = m * transform;
+


You don't have to do this when the prim path is the default pseudo root.

And same above in usdProxyShapeAdaptor

mattyjams · 2021-02-24T18:04:39Z

@mattyjams I moved the dependency between primPathAttr and inStageDataCachedAttr from ProxyShapeBase to ProxyShape
because we are currently have issue when the primPath changed. When we are re-computing the stage cache, if the stage is not found in a file (stage created in memory) we are creating a new in memory stage which override the current one.

Do you have any concern about this change ?

I think we should be fine with this change, since the dependency is still intact from the point of the pxrUsdProxyShape.

I'm hoping that the performance impact of computing the local transform in _Sync() in pxrUsdMayaGL will be relatively minimal, since our typical use case is to fill the primPath attribute with a root prim (e.g. /Asset) that has no transform.

mattyjams

Seems reasonable to me, though I'd agree with @kxl-adsk that the transform computation can be avoided when usdPrim() yields the psuedoroot or an invalid prim.

lib/mayaUsd/render/pxrUsdMayaGL/usdProxyShapeAdapter.cpp

…m Path -Only compute prim transform is the prim is not the root - Fix typos -Add VP2 test

…m Path -clang format

kxl-adsk

We have to support older versions of USD. Please see my comments below with suggestions on how to fix compilation errors for all supported versions of USD.

lib/mayaUsd/render/pxrUsdMayaGL/usdProxyShapeAdapter.cpp

lib/mayaUsd/render/vp2RenderDelegate/proxyRenderDelegate.cpp

…m Path -Fix build for minimum supported version of USD, i.e. 20.02.

…m Path -Fix maya scene fix test (remove required maya version and use relative path to the usd fle)

…m Path -Update the usd test file to add color on prim to avoid weird image generation on diffirent computer (bug to investigate). - Update the images test

MAYA-107276 - As a user, on the stage AE template I'd like to use Pri…

5ce3def

…m Path -Add Prim Path field in attribute editor -Use the prime path to render with VP2RenderDelegate -Change prim path tooltip

spinell-adsk requested a review from seando-adsk February 17, 2021 19:15

spinell-adsk assigned ecp-maya-devops-adsk Feb 17, 2021

seando-adsk reviewed Feb 18, 2021

View reviewed changes

seando-adsk approved these changes Feb 18, 2021

View reviewed changes

seando-adsk added the do-not-merge-yet Development is not finished, PR not ready for merge label Feb 18, 2021

spinell-adsk added 3 commits February 22, 2021 12:09

MAYA-107276 - As a user, on the stage AE template I'd like to use Pri…

17f4d0f

…m Path -Fix transform issue when using primPath -Move primPathAttr dependacy with inStageDataCachedAttr from ProxyShapeBase to ProxyShape to avoid issue when when primPath is dirty (stage in memory get cleared)

Merge branch 'dev_public' into spinell/MAYA-107276/ae_primpath

7d7a32f

# Conflicts: # plugin/adsk/scripts/AEmayaUsdProxyShapeTemplate.mel

Merge branch 'dev_public' into spinell/MAYA-107276/ae_primpath

93574d5

# Conflicts: # plugin/adsk/scripts/AEmayaUsdProxyShapeBaseTemplate.mel

spinell-adsk assigned ecp-maya-devops-adsk and unassigned ecp-maya-devops-adsk Feb 22, 2021

spinell-adsk requested review from kxl-adsk and mattyjams February 22, 2021 17:53

spinell-adsk commented Feb 22, 2021

View reviewed changes

MAYA-107276 - As a user, on the stage AE template I'd like to use Pri…

5df68ca

…m Path Fix clang format

spinell-adsk assigned ecp-maya-devops-adsk and unassigned ecp-maya-devops-adsk Feb 23, 2021

kxl-adsk suggested changes Feb 24, 2021

View reviewed changes

mattyjams approved these changes Feb 24, 2021

View reviewed changes

lib/mayaUsd/render/pxrUsdMayaGL/usdProxyShapeAdapter.cpp Outdated Show resolved Hide resolved

MAYA-107276 - As a user, on the stage AE template I'd like to use Pri…

f5aa78a

…m Path -Only compute prim transform is the prim is not the root - Fix typos -Add VP2 test

spinell-adsk removed the do-not-merge-yet Development is not finished, PR not ready for merge label Feb 26, 2021

spinell-adsk assigned ecp-maya-devops-adsk and unassigned ecp-maya-devops-adsk Feb 26, 2021

MAYA-107276 - As a user, on the stage AE template I'd like to use Pri…

3e684d9

…m Path -clang format

spinell-adsk assigned ecp-maya-devops-adsk and unassigned ecp-maya-devops-adsk Feb 26, 2021

kxl-adsk approved these changes Mar 2, 2021

View reviewed changes

kxl-adsk added the proxy Related to base proxy shape label Mar 3, 2021

kxl-adsk added ready-for-merge Development process is finished, PR is ready for merge and removed ready-for-merge Development process is finished, PR is ready for merge labels Mar 3, 2021

kxl-adsk suggested changes Mar 3, 2021

View reviewed changes

lib/mayaUsd/render/pxrUsdMayaGL/usdProxyShapeAdapter.cpp Outdated Show resolved Hide resolved

lib/mayaUsd/render/vp2RenderDelegate/proxyRenderDelegate.cpp Outdated Show resolved Hide resolved

MAYA-107276 - As a user, on the stage AE template I'd like to use Pri…

16d497d

…m Path -Fix build for minimum supported version of USD, i.e. 20.02.

kxl-adsk approved these changes Mar 3, 2021

View reviewed changes

kxl-adsk added ready-for-merge Development process is finished, PR is ready for merge and removed ready-for-merge Development process is finished, PR is ready for merge labels Mar 3, 2021

spinell-adsk added 2 commits March 9, 2021 13:53

MAYA-107276 - As a user, on the stage AE template I'd like to use Pri…

7689335

…m Path -Fix maya scene fix test (remove required maya version and use relative path to the usd fle)

MAYA-107276 - As a user, on the stage AE template I'd like to use Pri…

21d260f

…m Path -Update the usd test file to add color on prim to avoid weird image generation on diffirent computer (bug to investigate). - Update the images test

kxl-adsk assigned ecp-maya-devops-adsk and unassigned ecp-maya-devops-adsk Mar 12, 2021

kxl-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Mar 12, 2021

kxl-adsk merged commit 67f73fb into dev Mar 12, 2021

kxl-adsk deleted the spinell/MAYA-107276/ae_primpath branch March 12, 2021 10:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MAYA-107276 - As a user, on the stage AE template I'd like to use Pri… #1189

MAYA-107276 - As a user, on the stage AE template I'd like to use Pri… #1189

spinell-adsk commented Feb 17, 2021

seando-adsk Feb 18, 2021

spinell-adsk commented Feb 18, 2021

spinell-adsk left a comment •

edited

Loading

spinell-adsk Feb 22, 2021

kxl-adsk Feb 24, 2021

kxl-adsk left a comment •

edited

Loading

kxl-adsk Feb 24, 2021

kxl-adsk Feb 24, 2021

mattyjams commented Feb 24, 2021

mattyjams left a comment

kxl-adsk left a comment

MAYA-107276 - As a user, on the stage AE template I'd like to use Pri… #1189

MAYA-107276 - As a user, on the stage AE template I'd like to use Pri… #1189

Conversation

spinell-adsk commented Feb 17, 2021

seando-adsk Feb 18, 2021

Choose a reason for hiding this comment

spinell-adsk commented Feb 18, 2021

spinell-adsk left a comment • edited Loading

Choose a reason for hiding this comment

spinell-adsk Feb 22, 2021

Choose a reason for hiding this comment

kxl-adsk Feb 24, 2021

Choose a reason for hiding this comment

kxl-adsk left a comment • edited Loading

Choose a reason for hiding this comment

kxl-adsk Feb 24, 2021

Choose a reason for hiding this comment

kxl-adsk Feb 24, 2021

Choose a reason for hiding this comment

mattyjams commented Feb 24, 2021

mattyjams left a comment

Choose a reason for hiding this comment

kxl-adsk left a comment

Choose a reason for hiding this comment

spinell-adsk left a comment •

edited

Loading

kxl-adsk left a comment •

edited

Loading