Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the nurbs curve selection mask for basis curves. #1208

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Use the nurbs curve selection mask for basis curves. #1208

merged 1 commit into from
Feb 25, 2021

Conversation

williamkrick
Copy link
Contributor

kSelectCurves includes kSelectSurfaceEdge which has a higher priority that causes issues.

This addresses #951

Use the nurbs curve selection mask for basis curves. kSelectCurves in…
d05689f 
…cludes kSelectSurfaceEdge which has a higher priority that causes issues.
@williamkrick williamkrick added the vp2renderdelegate Related to VP2RenderDelegate label Feb 24, 2021
@huidong-chen
Copy link

LGTM. Thanks for fixing the issue.

Maybe one addition test: can you check off Select curve objects button in the Maya tools and see whether we are still able to use that setting to control whether we want to select USD curves or not?

image

@williamkrick
Copy link
Contributor Author

With Select curve objects disabled I am not able to pick basisCurves in the viewport, which seems like the correct behavior.

@williamkrick williamkrick added the ready-for-merge Development process is finished, PR is ready for merge label Feb 25, 2021
@huidong-chen
Copy link

Cool. Thanks for confirming.

@kxl-adsk kxl-adsk merged commit 04a14fc into dev Feb 25, 2021
@kxl-adsk kxl-adsk deleted the krickw/MAYA-109889/use_correct_selection_mask_for_basisCurves branch February 25, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huidong-chen huidong-chen huidong-chen approved these changes

Assignees

@ecp-maya-devops-adsk ecp-maya-devops-adsk

Labels
ready-for-merge Development process is finished, PR is ready for merge vp2renderdelegate Related to VP2RenderDelegate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@williamkrick @huidong-chen @kxl-adsk @ecp-maya-devops-adsk