move import of ufeSelectCmd inside selectPath() function in ufeUtils #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to import ufeSelectCmd before maya.standalone.initialize() has been called will raise an ImportError and cause tests to fail. For example, this would be the case for test cases that are decorated with the unittest.skipUnless() decorator and use ufeUtils.ufeFeatureSetVersion(), since the decorator will be executed before setUpClass has a chance to run and initialize maya.standalone. This change addresses that by pushing the import of ufeSelectCmd into the selectPath() function where it is used rather than having it at the top of the file. This ensures that the ufeUtils module can be imported and ufeUtils.ufeFeatureSetVersion() can be called safely before maya.standalone.initialize().
ppt-adsk
approved these changes
Mar 8, 2021
kxl-adsk
added
the
ready-for-merge
mattyjams
deleted the
pr/allow_ufeUtils_ufeFeatureSetVersion_before_maya_standalone_initialize
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to import
ufeSelectCmdbeforemaya.standalone.initialize()has been called will raise anImportErrorand cause tests to fail. For example, this would be the case for test cases that are decorated with theunittest.skipUnless()decorator and useufeUtils.ufeFeatureSetVersion(), since the decorator will be executed beforesetUpClasshas a chance to run and initializemaya.standalone.This change addresses that by pushing the import of
ufeSelectCmdinto theselectPath()function where it is used rather than having it at the top of the file. This ensures that theufeUtilsmodule can be imported andufeUtils.ufeFeatureSetVersion()can be called safely beforemaya.standalone.initialize().Note that this does not currently manifest as an issue when running the unit tests using the CMake infrastructure in this repo since we inject the Maya standalone initialization early in every test:
maya-usd/cmake/test.cmake
Line 154 in d1fe7cd
We do not do that in our internal test infrastructure, which is why this is problematic for us. Ultimately, it seems like it would be preferable not do to that in CMake either and make sure that every test script can run successfully on its own without requiring additional patching from the test harness. There are likely other changes along the lines of this one needed to make that a reality, but this is hopefully one more small step in that direction.