Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-104490 Add a basic test for Vp2RenderDelegate geom subset material binding support. #1255

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

williamkrick
Copy link
Contributor

No description provided.

@huidong-chen
Copy link

It looks to me the test scene can be added to RTS without having to add the test script separately since you only capture the image of unselected case. Why do you choose to do it this way?

@williamkrick
Copy link
Contributor Author

It looks to me the test scene can be added to RTS without having to add the test script separately since you only capture the image of unselected case. Why do you choose to do it this way?

I like the test here for two reasons: it is in a public place so our partners can run it when validating their own changes and because these tests can run before a change is merged, while RTS runs after. The sooner we get the results from the test the better!

Right now the interactive tests (including this one) are not run as a part of the preflight before a merge, but we're hoping to get that working eventually.

@huidong-chen
Copy link

That is convincing. Thanks for clarification.

@kxl-adsk
Copy link

And just to bring one more argument to the mix. Regression tests are run across multiple USD versions and Maya versions. RTS doesn't have this setup.

@kxl-adsk kxl-adsk merged commit 5da577e into dev Mar 16, 2021
@kxl-adsk kxl-adsk deleted the krickw/MAYA-104490/geom_subsets_test branch March 16, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vp2renderdelegate Related to VP2RenderDelegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants