Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-110596 MAYA-110576 faster point snapping #1292

Conversation

huidong-chen
Copy link

@huidong-chen huidong-chen commented Mar 30, 2021

The component level is coarse-grain, causing Maya to produce selection hits with undesired selection levels, i.e. face/edge selection hits, as well as vertex selection hits that are required by point snapping. Switch to the new vertex selection level if available in order to produce vertex selection hits only.

@huidong-chen huidong-chen added pending beta This issue or PR will be testable in next beta release vp2renderdelegate Related to VP2RenderDelegate do-not-merge-yet Development is not finished, PR not ready for merge labels Mar 30, 2021
@huidong-chen
Copy link
Author

@williamkrick @JGamache-autodesk The required API change has been backported so I pushed a new commit to update the Maya API version check.

Viewport 2.0 is now able to use regular items for point snapping,
thus VP2RenderDelegate doesn't have to create and update the
dedicated point snapping items.
@huidong-chen
Copy link
Author

As suggested by Krystian , I included the commit which is to solve another task of the point snapping performance epic in this pull request, in order to make it easier for partners to validate when ready.

I will need more testing before asking William and Jerry to review again.

@huidong-chen
Copy link
Author

As commented above, I pushed another commit to this pull request which is to skip creating/updating point snapping items when maya has the new point snapping support. It is now ready for review. Thanks.

We need to keep selection update enabled to avoid querying some global
states frequently: selection by kind, selection list adjustment etc.
@huidong-chen
Copy link
Author

huidong-chen commented Apr 14, 2021

Aside from new commits to pass clang_format_linter and pre-flight, I also make a new commit (a106699) to keep selection update enabled, which is to reduce frequency of calling GetSelectionKind(), GetPointInstancesPickMode() and GetListAdjustment(), from once per selection hit to once per selection pass.

@huidong-chen huidong-chen changed the title MAYA-110596 switch to vertex selection level for point snapping MAYA-110596 MAYA-110576 faster point snapping Apr 14, 2021
@huidong-chen
Copy link
Author

@JGamache-autodesk Can you please review commit a106699?

@kxl-adsk kxl-adsk added ready-for-merge Development process is finished, PR is ready for merge and removed do-not-merge-yet Development is not finished, PR not ready for merge pending beta This issue or PR will be testable in next beta release labels Apr 21, 2021
@kxl-adsk kxl-adsk merged commit 600c31a into dev Apr 21, 2021
@kxl-adsk kxl-adsk deleted the chenh/MAYA-110596/switch-to-vertex-selection-level-for-point-snapping branch April 21, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge vp2renderdelegate Related to VP2RenderDelegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants