-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAYA-110596 MAYA-110576 faster point snapping #1292
MAYA-110596 MAYA-110576 faster point snapping #1292
Conversation
@williamkrick @JGamache-autodesk The required API change has been backported so I pushed a new commit to update the Maya API version check. |
Viewport 2.0 is now able to use regular items for point snapping, thus VP2RenderDelegate doesn't have to create and update the dedicated point snapping items.
As suggested by Krystian , I included the commit which is to solve another task of the point snapping performance epic in this pull request, in order to make it easier for partners to validate when ready. I will need more testing before asking William and Jerry to review again. |
As commented above, I pushed another commit to this pull request which is to skip creating/updating point snapping items when maya has the new point snapping support. It is now ready for review. Thanks. |
We need to keep selection update enabled to avoid querying some global states frequently: selection by kind, selection list adjustment etc.
Aside from new commits to pass clang_format_linter and pre-flight, I also make a new commit (a106699) to keep selection update enabled, which is to reduce frequency of calling |
@JGamache-autodesk Can you please review commit a106699? |
The component level is coarse-grain, causing Maya to produce selection hits with undesired selection levels, i.e. face/edge selection hits, as well as vertex selection hits that are required by point snapping. Switch to the new vertex selection level if available in order to produce vertex selection hits only.