-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAYA-111095 - [GitHub #1340] Mute layer doesn't work when a Layer is … #1423
Conversation
…loaded through Load Sublayer -Update layerEditorCommand to use the layer identifier when adding a subLayerPath
When loading a layer from the layer editor "Load sublayers..." menu, we are using the filesystem path as an argument for When USD need to build the layer stack in (PcpLayerStack::_BuildLayerStack()), it's check inside a cache if a sublayer is muted or not by using the subLayerPath. The cache is filled by function like USDCache::MuteLayer() which take the layer identifier as parameter. So, when USD check inside the cache to know which layer are mutes, it do a string comparation between the sublayerPath and the layer identifier which can be different on Windows. On Windows, If a layer's path is absolute, the layer's identifier will be the path but the driver letter will always be in lower case. To fix this issue I think there is 2 solutions. I checked inside USD codebase (Python/c++ tests) and they are always using identifier with Sdf::InsertSubLayerPath() so I choose this way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to add an automated test for this?
…loaded through Load Sublayer -Add test and comments.
@ppt-adsk I have added a test for the mute command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice test!
…loaded through Load Sublayer
-Update layerEditorCommand to use the layer identifier when adding a subLayerPath